vendor archive not recognized as valid tarball

[jpalus]

I've started packaging libpathrs for my distribution and stumbled upon error to recognize file format of libpathrs.vendor.tar.zst:

$ tar tf libpathrs.vendor.tar.zst 
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors

I thought maybe something is off with my system so double checked in Fedora:

podman run -it --rm fedora sh -c "curl -sL https://github.com/cyphar/libpathrs/releases/download/v0.2.5/libpathrs.vendor.tar.zst|tar t --zstd" 
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors

Same outcome. Perhaps openSUSE does something differently:

$ podman run -it --rm opensuse/leap sh -c "zypper -nq install zstd; curl -sL https://github.com/cyphar/libpathrs/releases/download/v0.2.5/libpathrs.vendor.tar.zst|tar t --zstd" 
 
The following NEW package is going to be installed:
  zstd

...

tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors

As a last resort maybe bsdtar can handle it:

$ bsdtar tf libpathrs.vendor.tar.zst 
bsdtar: Error opening archive: Unrecognized archive format

Any idea what am I doing wrong?

[jpalus]

Side note: since this appears to be Linux-only library consider using https://github.com/coreos/cargo-vendor-filterer/ which reduces vendor dir size significantly.

[cyphar]

Ah dammit, this is a bug in my release script. The file is a tar archive but it has the output of cargo vendor prepended to it because I was trying to be too clever with shell pipelines (if you look at it with xxd you can see how I screwed it up). Let me fix that and re-push the artifact...

I should just mention that you shouldn't feel pressured to use the released vendor/ tree I provide -- we don't use it in openSUSE. I only include it in releases for people who have build systems that do not have a nice mechanism to fetch the dependencies listed in Cargo.lock nicely. In OBS we have a service for it, and I'm sure most distributions have a mechanism that means that you don't really need libpathrs.vendor.tar.zstd.

Side note: since this appears to be Linux-only library consider using https://github.com/coreos/cargo-vendor-filterer/ which reduces vendor dir size significantly.

At the moment this is Linux-only but I do plan to support other *nix operating systems at some point. I'll take a look at this tool though...

[cyphar]

#402 fixes the script and adds a new CI job to make sure that tar tvf at least works, and I've pushed fixed libpathrs.vendor.tar.zst archives to the 0.2.5 and 0.2.4 releases.