feat(protocol): design-baseline Phase 2 — multi-persona sub-agent design review#6
Open
d-wwei wants to merge 2 commits into
Open
feat(protocol): design-baseline Phase 2 — multi-persona sub-agent design review#6d-wwei wants to merge 2 commits into
d-wwei wants to merge 2 commits into
Conversation
Reviewed 13-section spec for Plan Agent orchestration architecture.
Fixed 3 blocking issues (P0) and 4 important issues (P1):
- P0-1: Rename orchestration daemon CLI to `apex orch` (avoid collision
with existing `apex daemon` for Dashboard launchd)
- P0-2: Define spawnUnblockedTasks — daemon spawns via `apex worker spawn`
CLI, reads meta.json for WindowHandle tracking
- P0-3: Clarify Section 6.2 (agentStartCommand) is in-scope, narrow
Section 13 未覆盖 list accordingly
- P1-1: Replace broken autoIntegrate shell script with temporary worktree
- P1-2: Add autoMerge definition (git merge --ff after integrate passes)
- P1-3: Fix lock file TOCTOU with atomic writeFileSync({flag:'wx'})
- P1-4: Specify daemon as M&C exit condition detector
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ign review Implement Phase 2 of the design-baseline gate: 5 expert persona sub-agents (UX Designer, Accessibility Specialist, Brand Guardian, Performance Analyst, End User) dispatched in parallel for independent design review. Key additions: - Persona prompt templates with evaluation questions and anti-rubber-stamping rules - Conflict detection (action conflicts + severity conflicts) with surfacing protocol - Verdict aggregation via confidence voting with explicit precedence (BLOCK > ESCALATE > PASS_WITH_NOTE > PASS) - CONCERN verdict classification, minimum 3-persona guardrail, all-disabled guard clause - Output transformation mapping persona findings to canonical review format - Artifact integration section for per-persona findings in review doc Architecture change: Phase 2 subsumes tasteful-frontend in Review layer. tasteful-frontend retained in Execute stage for design spec generation. Also includes: quick compound for previous iteration (compound memory write enforcement). Requirements: docs/brainstorms/design-baseline-phase2-requirements.md Plan: docs/plans/design-baseline-phase2-plan.md Review: docs/reviews/design-baseline-phase2-review.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed Files
skill/gates/design-baseline.md— Core Phase 2 implementation (+370 lines)skill/bindings.yaml— Remove tasteful-frontend from review layersskill/stages/review.md— Update Skill Dispatch descriptionskill/aliases/design-review.md— Update alias to Phase 1 + Phase 2 flowdocs/— Requirements, plan, review, solution doc, roadmap snapshotTest plan
🤖 Generated with Claude Code