imageio_dng.c error: ‘TIFFTAG_PREVIEWCOLORSPACE’ undeclared (first use in this function)

[esq4]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

when compiling:

....
/home/a/darktable/src/imageio/imageio_dng.c: In function ‘_register_extra_dng_fields’:
/home/a/darktable/src/imageio/imageio_dng.c:82:7: error: ‘TIFFTAG_PREVIEWCOLORSPACE’ undeclared (first use in this function)
   82 |     { TIFFTAG_PREVIEWCOLORSPACE, 1, 1, TIFF_LONG, FIELD_CUSTOM,
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~

Steps to reproduce

bash ../build.sh --prefix /opt/darktable --build-type Release --enable-ai

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

current master

What OS are you using?

Linux

What is the version of your OS?

debian 12

[victoryforce]

/home/a/darktable/src/imageio/imageio_dng.c:82:7: error: ‘TIFFTAG_PREVIEWCOLORSPACE’ undeclared (first use in this function)

TIFFTAG_PREVIEWCOLORSPACE was added in libtiff 4.5.1. This effectively becomes the minimum required version of libtiff for darktable

What is the version of your OS?

debian 12

debian 12 has libtiff 4.5.0

[andriiryzhkov]

This is an old libtiff. We can guard TIFFTAG_PREVIEWCOLORSPACE fallback.

[andriiryzhkov]

Fixed in #20933