Skip to content

Commit 490091c

Browse files
committed
Small fixes
1 parent 60c0890 commit 490091c

4 files changed

Lines changed: 4 additions & 2 deletions

File tree

databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/RefreshableTokenSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ protected Token getTokenAsync() {
213213
* Trigger an asynchronous refresh of the token if not already in progress and last refresh
214214
* succeeded.
215215
*/
216-
protected synchronized void triggerAsyncRefresh() {
216+
private synchronized void triggerAsyncRefresh() {
217217
// Check token state to avoid triggering a refresh if another thread has already refreshed it
218218
if (!refreshInProgress && lastRefreshSucceeded && getTokenState(token) != TokenState.FRESH) {
219219
refreshInProgress = true;

databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Token.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public String getAccessToken() {
7070
}
7171

7272
/**
73-
* Returns the expiry time of the token as a LocalDateTime.
73+
* Returns the expiry time of the token as a Instant.
7474
*
7575
* @return the expiry time
7676
*/

databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/DataPlaneTokenSourceTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ void testDataPlaneTokenSource(
194194
assertEquals(expectedToken.getAccessToken(), token.getAccessToken());
195195
assertEquals(expectedToken.getTokenType(), token.getTokenType());
196196
assertEquals(expectedToken.getRefreshToken(), token.getRefreshToken());
197+
assertTrue(expectedToken.getExpiry().isAfter(Instant.now()));
197198
}
198199
}
199200

databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/FileTokenCacheTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ void testSaveAndLoadToken() {
5454
assertEquals("access-token", loadedToken.getAccessToken());
5555
assertEquals("Bearer", loadedToken.getTokenType());
5656
assertEquals("refresh-token", loadedToken.getRefreshToken());
57+
assertEquals(expiry, loadedToken.getExpiry());
5758
}
5859

5960
@Test

0 commit comments

Comments
 (0)