dinitctl service description file access can fail if service directory is not absolute path

[mobin-2008]

When a relative service directory path is specified via dinit -d service-dir, dinitctl is not able to open/access service directory files within the directory (unless it happens to get launched from the same directory that dinit started in). In the worst case it could open the wrong file.

This currently affects both enable/disable and start commands (where the modification time of the file is checked in order to warn if the service description needs to be reloaded).

The easiest fix for the time being is probably to make the SVCDSCDIR request return a resolved path, but this needs a little consideration. Another option is to disallow relative service directory paths.

See #550 (comment)

[davmac314]

From the PR comment:

Perhaps that should be made to work, let me think on it.

Why did you open an issue?

[mobin-2008]

From the PR comment:

Perhaps that should be made to work, let me think on it.

Why did you open an issue?

I reported that in the PR to make sure it's a real thing before opening an issue for it.

Because I think it's a separate issue deserving its issue. I also wanted to make sure that no further discussion about this issue will be in that PR which otherwise makes it harder for me to follow that PR.

[davmac314]

Because I think it's a separate issue deserving its issue

I specifically asked you to let me think on it.

[mobin-2008]

Because I think it's a separate issue deserving its issue

I specifically asked you to let me think on it.

I didn't know I shouldn't even open an issue for it.

[davmac314]

I didn't know I shouldn't even open an issue for it.

I even crossed out the earlier comment that asked you to open an issue.

Ok, I get that this was a misunderstanding. But for future reference, if I say something like "let me think on it" that means: I will handle it, don't do anything yourself.