diff --git a/deepnote_toolkit/sql/sql_execution.py b/deepnote_toolkit/sql/sql_execution.py index bf045bb..77ea872 100644 --- a/deepnote_toolkit/sql/sql_execution.py +++ b/deepnote_toolkit/sql/sql_execution.py @@ -342,9 +342,8 @@ def _handle_federated_auth_params(sql_alchemy_dict: dict[str, Any]) -> None: "Invalid federated auth params, try updating toolkit version" ) elif federated_auth.integrationType == "snowflake": - logger.warning( - "Snowflake federated auth is not supported yet, using the original connection URL" - ) + # Snowflake federated auth is not supported yet, using the original connection URL + pass else: logger.error( "Unsupported integration type: %s, try updating toolkit version", diff --git a/tests/unit/test_sql_execution.py b/tests/unit/test_sql_execution.py index bf9f4d9..de46ba4 100644 --- a/tests/unit/test_sql_execution.py +++ b/tests/unit/test_sql_execution.py @@ -721,10 +721,9 @@ def test_federated_auth_params_bigquery(self, mock_get_credentials): "test-bigquery-access-token", ) - @mock.patch("deepnote_toolkit.sql.sql_execution.logger") @mock.patch("deepnote_toolkit.sql.sql_execution._get_federated_auth_credentials") - def test_federated_auth_params_snowflake(self, mock_get_credentials, mock_logger): - """Test that Snowflake federated auth logs a warning since it's not supported yet.""" + def test_federated_auth_params_snowflake(self, mock_get_credentials): + """Test that Snowflake federated auth doesn't do anything since it's not supported yet.""" from deepnote_toolkit.sql.sql_execution import ( FederatedAuthResponseData, _handle_federated_auth_params, @@ -757,11 +756,6 @@ def test_federated_auth_params_snowflake(self, mock_get_credentials, mock_logger "test-snowflake-integration-id", "test-snowflake-auth-context-token" ) - # Verify a warning was logged - mock_logger.warning.assert_called_once_with( - "Snowflake federated auth is not supported yet, using the original connection URL" - ) - # Verify params were NOT modified (snowflake is not supported yet) self.assertEqual(sql_alchemy_dict["params"], original_params)