ci: declare empty permissions on release workflow#643
Merged
bartlomieju merged 2 commits intoJun 8, 2026
Conversation
The release job authenticates every write path through DENOBOT_PAT:
the actions/checkout step pulls with that token, and the tag-and-
release step explicitly sets GITHUB_TOKEN=${{ secrets.DENOBOT_PAT }}
when invoking @deno/rust-automation publish-release. The workflow's
own GITHUB_TOKEN is unused.
permissions: {} at the job level documents that and matches the
per-job style used by ci.yml and publish.yml (contents:read +
id-token:write).
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
|
bartlomieju
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the release job to
permissions: {}. Every write path authenticates throughDENOBOT_PAT:actions/checkoutpulls with that token, and the tag-and-release step explicitly overridesGITHUB_TOKENto${{ secrets.DENOBOT_PAT }}before invoking@deno/rust-automation/tasks/publish-release. The workflow's ownGITHUB_TOKENis never used.Defense-in-depth angle is CVE-2025-30066: a compromised third-party action (
denoland/setup-deno,dsherret/rust-toolchain-file) runs inside the job context and exfiltrates the workflow token via logs. Withpermissions: {}, the token has nothing to leak; publish authority lives only inDENOBOT_PAT.Matches the per-job
contents: read+id-token: writeblocks already inci.ymlandpublish.yml. YAML validated locally withyaml.safe_load.