Skip to content

fix(fast_check): strip private declare field decorators#646

Merged
bartlomieju merged 3 commits into
mainfrom
orch/issue-102-fast-check-decorators
Jun 8, 2026
Merged

fix(fast_check): strip private declare field decorators#646
bartlomieju merged 3 commits into
mainfrom
orch/issue-102-fast-check-decorators

Conversation

@fibibot

@fibibot fibibot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Fixes denoland/deno#33753.\n\nFast-check rewrites TS-private class fields to declaration-style private properties. When the original field has a decorator, the generated output kept that decorator on a declare private field, which TypeScript rejects with TS1206.\n\nThis clears decorators when transforming TS-private class properties into fast-check declaration fields and adds a regression test for the generated source.\n\nAI assisted: yes.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


exe.dev user seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@neonbyte1

Copy link
Copy Markdown

@bartlomieju in which upcoming release can we expect that the issue is resolved? :) 2.8 was just released

@bartlomieju bartlomieju merged commit 5c3e9ef into main Jun 8, 2026
19 checks passed
@bartlomieju bartlomieju deleted the orch/issue-102-fast-check-decorators branch June 8, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deno publish Decorators are not valid here - Failed ensuring public API type output is valid

4 participants