fix(fast_check): strip private declare field decorators#646
Merged
Conversation
|
exe.dev user seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@bartlomieju in which upcoming release can we expect that the issue is resolved? :) 2.8 was just released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes denoland/deno#33753.\n\nFast-check rewrites TS-private class fields to declaration-style private properties. When the original field has a decorator, the generated output kept that decorator on a
declare privatefield, which TypeScript rejects with TS1206.\n\nThis clears decorators when transforming TS-private class properties into fast-check declaration fields and adds a regression test for the generated source.\n\nAI assisted: yes.