[MAGENTO] Check That bin/magento Exists In Previous Release#4230
Open
null93 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During the magento:cron:stop task, we check to see if the
previous_releasevariable is set. If it is then we try to runbin/magento cron:removefrom the previous release's directory.The problem is if the previous release fails before copying data into the release directory, then there is no
bin/magentoin the previous release folder.The
previous_releasevariable is set by just sorting the release names and not considering if its a successful release (release.php#L139-L141).When this happens it fails with this kind of error message:
Solution
The solution is really simple, just test if the
bin/magentofile exists in the previous release folder:Bug fix #…? Yes but no issue number
New feature? No
BC breaks? No
Tests added? No
Docs added? Ran command, nothing changed