Commit 3e1b0f6
refactor(editor): tasks.json 廃止で dead code 化した container_name 引数を削除
_maybe_place_terminal_task 削除により container_name の唯一の供給元が消え、
_maybe_open_editor / open_editor の container_name 引数は常に None となる
dead code になっていた。gemini レビュー指摘に従い以下を整理する。
- _maybe_open_editor: container_name 引数と docstring 説明・open_editor への伝播を削除
- open_editor: container_name 引数と docstring 説明を削除し
container = resolve_container_name(...) に簡約
- test_open_editor_uses_given_container_name テストを削除
build_attach_uri / resolve_container_name / _query_container_name は別物のため不変更。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 37b6e3f commit 3e1b0f6
3 files changed
Lines changed: 3 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
419 | | - | |
| 419 | + | |
420 | 420 | | |
421 | 421 | | |
422 | 422 | | |
| |||
429 | 429 | | |
430 | 430 | | |
431 | 431 | | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | 432 | | |
436 | 433 | | |
437 | 434 | | |
| |||
456 | 453 | | |
457 | 454 | | |
458 | 455 | | |
459 | | - | |
460 | 456 | | |
461 | 457 | | |
462 | 458 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
465 | | - | |
| 465 | + | |
466 | 466 | | |
467 | 467 | | |
468 | 468 | | |
| |||
472 | 472 | | |
473 | 473 | | |
474 | 474 | | |
475 | | - | |
476 | | - | |
477 | 475 | | |
478 | 476 | | |
479 | 477 | | |
| |||
487 | 485 | | |
488 | 486 | | |
489 | 487 | | |
490 | | - | |
| 488 | + | |
491 | 489 | | |
492 | 490 | | |
493 | 491 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
508 | 508 | | |
509 | 509 | | |
510 | 510 | | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | 511 | | |
531 | 512 | | |
532 | 513 | | |
| |||
0 commit comments