fix(plugin): repo refresh の壊れた移行を成功扱いにせず移行時の registry.yml 重複パースを抑制

- refresh_repository: _update_repo_plugins が repo_errors を返した場合は
  warning で握りつぶさず RepositoryError として伝播。pull 後に削除された
  プラグインの移行失敗を成功扱いにしない (major)
- migrate: 同一リポジトリの複数プラグイン移行時、local_path fast path で
  返る registry.yml の遅延パースを URL 単位でキャッシュしリポジトリあたり
  1 回に抑制 (minor / performance)
- 両挙動の回帰テストを追加

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: takemi-ohama

lib/devbase/plugin/migrator.py

@@ -434,6 +434,12 @@ def migrate(registry: PluginRegistry, *, run_sync: bool = True) -> MigrationResu
         repo.url: repo for repo in registry.list_repositories() if repo.url
     }
 
+    # Cache the lazily-parsed registry.yml per repo URL. On the healthy
+    # local_path fast path _ensure_repo_cloned returns reg_info=None, so a repo
+    # with multiple legacy plugins would otherwise re-parse the same registry.yml
+    # once per plugin here; the cache collapses that to one parse per repo.
+    reg_info_by_url: dict[str, Optional["RegistryInfo"]] = {}
+
     for plugin in legacy:
         try:
             repo = repos_by_url.get(plugin.source) if plugin.source else None
@@ -450,10 +456,13 @@ def migrate(registry: PluginRegistry, *, run_sync: bool = True) -> MigrationResu
             )
 
             # _ensure_repo_cloned already parsed registry.yml on the clone/reuse
-            # paths; only the healthy local_path fast path returns None, so parse
-            # lazily there instead of unconditionally re-reading the same file.
+            # paths; only the healthy local_path fast path returns None. Parse
+            # lazily there, but reuse a cached parse for subsequent plugins of
+            # the same repo instead of re-reading the same file each iteration.
             if reg_info is None:
-                reg_info = parse_registry_yml(clone_dir)
+                if repo.url not in reg_info_by_url:
+                    reg_info_by_url[repo.url] = parse_registry_yml(clone_dir)
+                reg_info = reg_info_by_url[repo.url]
             entry = None
             if reg_info:
                 entry = next(

lib/devbase/plugin/repo_manager.py

@@ -457,8 +457,17 @@ def refresh_repository(
         pre_pull_projects=pre_pull_projects,
     )
     if repo_errors:
+        # A failed removal-migration leaves the stale plugins/ entry in
+        # plugins.yml; reporting "refreshed" here would mask that broken
+        # install state. Surface it as a hard error (mirrors update_plugin,
+        # which raises on _update_repo_plugins errors) instead of warning and
+        # exiting 0.
         for err in repo_errors:
-            logger.warning("  %s", err)
+            logger.error("  %s", err)
+        raise RepositoryError(
+            f"Repository '{repo.name}' refresh left plugins in a broken state:\n"
+            + "\n".join(f"  - {e}" for e in repo_errors)
+        )
     if sync:
         sync_projects(registry)
 

tests/plugin/test_migrator.py

@@ -415,6 +415,36 @@ def fake_clone(url, dest, **kwargs):
         assert registry.get("adminer").path == f"repos/{DIRNAME}/adminer"
 
 
+    def test_registry_yml_parsed_once_for_multiple_plugins_same_repo(
+        self, registry, devbase_root
+    ):
+        # Two legacy plugins from the same repo with a healthy local_path clone:
+        # _ensure_repo_cloned takes the fast path (returns reg_info=None) for
+        # both, so migrate()'s per-URL reg_info cache must collapse the lazy
+        # registry.yml parse to one per repo instead of one per plugin.
+        plugins = [
+            {"name": "p1", "path": "p1", "projects": ["p1"]},
+            {"name": "p2", "path": "p2", "projects": ["p2"]},
+        ]
+        _make_repo_clone(devbase_root, plugins)
+        _register_repo(registry, plugins)
+        for p in plugins:
+            _make_legacy_copy(devbase_root, p["name"], p)
+            registry.add(_installed(p["name"], f"plugins/{p['name']}"))
+
+        import devbase.plugin.installer as installer_mod
+        real_parse = installer_mod.parse_registry_yml
+        with patch(
+            "devbase.plugin.installer.parse_registry_yml",
+            side_effect=real_parse,
+        ) as spy_parse:
+            result = migrate(registry)
+
+        assert sorted(result.migrated) == ["p1", "p2"]
+        # Without the cache this would be 2 (one lazy parse per plugin).
+        assert spy_parse.call_count == 1
+
+
 class TestMigrateKeepsLinked:
     def test_linked_install_keeps_plugins_dir(self, registry, devbase_root):
         plugins = [{"name": "adminer", "path": "adminer", "projects": ["adminer"]}]

tests/plugin/test_repos_core.py

@@ -334,6 +334,29 @@ def test_refresh_warns_removed_installed_plugin(self, registry, devbase_root):
                 "p1", "testrepo",
             )
 
+    def test_refresh_raises_when_update_repo_plugins_errors(
+        self, registry, devbase_root
+    ):
+        # A failed removal-migration leaves the stale plugins/ entry in
+        # plugins.yml; refresh must surface that as RepositoryError rather than
+        # warning-and-exiting-0 (otherwise `devbase plugin repo refresh` reports
+        # success on a broken install state).
+        url = "https://github.com/testorg/testrepo.git"
+        _make_repo_dir(devbase_root, "testorg/testrepo", [
+            {"name": "p1", "path": "p1"},
+        ])
+        _register_repo(registry, "testorg/testrepo", url, [
+            {"name": "p1", "path": "p1"},
+        ])
+
+        with patch("devbase.plugin.repo_manager._git_pull"), \
+             patch(
+                 "devbase.plugin.updater._update_repo_plugins",
+                 return_value=["Migration failed for 'p1'"],
+             ):
+            with pytest.raises(RepositoryError, match="broken state"):
+                refresh_repository(registry, "testrepo")
+
 
 # ── installer.py ────────────────────────────────────────────────