Skip to content

Commit 1f23940

Browse files
Merge pull request #245 from luisrudge/master
Fix importing json and superagent
2 parents b0c4b88 + 8907c6f commit 1f23940

7 files changed

Lines changed: 53 additions & 11 deletions

File tree

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ node_modules
22
.DS_Store
33
*.log
44
.rpt2_cache
5+
.rts2_cache_cjs
6+
.rts2_cache_es
7+
.rts2_cache_umd
58
build
69
dist
710
package-lock.json

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
"rollup-plugin-commonjs": "^9.0.0",
6464
"rollup-plugin-es3": "^1.1.0",
6565
"rollup-plugin-flow": "^1.1.1",
66+
"rollup-plugin-json": "^3.1.0",
6667
"rollup-plugin-node-resolve": "^3.3.0",
6768
"rollup-plugin-postcss": "^1.6.1",
6869
"rollup-plugin-preserve-shebang": "^0.1.6",

src/index.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import brotliSize from 'brotli-size';
1818
import prettyBytes from 'pretty-bytes';
1919
import shebangPlugin from 'rollup-plugin-preserve-shebang';
2020
import typescript from 'rollup-plugin-typescript2';
21+
import json from 'rollup-plugin-json';
2122
import flow from './lib/flow-plugin';
2223
import logError from './log-error';
2324
import { readFile, isDir, isFile, stdout, stderr } from './utils';
@@ -238,7 +239,6 @@ function createConfig(options, entry, format, writeMeta) {
238239
aliases['.'] = './' + basename(options.output);
239240
}
240241

241-
let useNodeResolve = true;
242242
const peerDeps = Object.keys(pkg.peerDependencies || {});
243243
if (options.external === 'none') {
244244
// bundle everything (external=[])
@@ -350,6 +350,15 @@ function createConfig(options, entry, format, writeMeta) {
350350
inject: false,
351351
extract: !!writeMeta,
352352
}),
353+
nodeResolve({
354+
module: true,
355+
jsnext: true,
356+
browser: options.target !== 'node',
357+
}),
358+
commonjs({
359+
include: 'node_modules/**',
360+
}),
361+
json(),
353362
useTypescript &&
354363
typescript({
355364
typescript: require('typescript'),
@@ -419,16 +428,6 @@ function createConfig(options, entry, format, writeMeta) {
419428
dangerousTaggedTemplateString: true,
420429
},
421430
}),
422-
useNodeResolve &&
423-
commonjs({
424-
include: 'node_modules/**',
425-
}),
426-
useNodeResolve &&
427-
nodeResolve({
428-
module: true,
429-
jsnext: true,
430-
browser: options.target !== 'node',
431-
}),
432431
// We should upstream this to rollup
433432
// format==='cjs' && replace({
434433
// [`module.exports = ${rollupName};`]: '',

test/__snapshots__/index.test.js.snap

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,34 @@ Build \\"basicCss\\" to dist:
5757
135 B: basic-css.umd.js.br"
5858
`;
5959

60+
exports[`fixtures basic-json 1`] = `
61+
"Used script: microbundle
62+
63+
Directory tree:
64+
65+
basic-json
66+
dist
67+
basic-json.js
68+
basic-json.js.map
69+
basic-json.mjs
70+
basic-json.mjs.map
71+
basic-json.umd.js
72+
basic-json.umd.js.map
73+
package.json
74+
src
75+
index.js
76+
two.json
77+
78+
79+
Build \\"basicJson\\" to dist:
80+
146 B: basic-json.js.gz
81+
97 B: basic-json.js.br
82+
145 B: basic-json.mjs.gz
83+
98 B: basic-json.mjs.br
84+
225 B: basic-json.umd.js.gz
85+
161 B: basic-json.umd.js.br"
86+
`;
87+
6088
exports[`fixtures basic-ts 1`] = `
6189
"Used script: microbundle
6290
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"name": "basic-json"
3+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import two from './two.json';
2+
3+
export default async function(...args) {
4+
return two;
5+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"test": "true"
3+
}

0 commit comments

Comments
 (0)