forked from digma-ai/forkof-spring-petclinic
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
Description
The MonitorService is currently throwing unhandled IllegalStateException errors in the monitor endpoint.
Error Details:
- Error ID: b2f3824a-3655-11f0-bc70-ca59c7e8e81d
- Message: "monitor failure"
- Occurrences: 25 times between May 21 and May 30, 2025
- Criticality Score: 75
Root Cause:
The service has several design issues:
- Improper state management
- isRunning() always returns false
- Unhandled exceptions in monitor() method
- No retry mechanism
- Intentional exception throwing for testing
Fix:
A PR has been created (#68) that implements the following improvements:
- Added proper state management using SystemStatus enum
- Fixed isRunning() to return actual state
- Added retry mechanism for monitor()
- Added proper exception handling with logging
- Removed the intentional exception throwing
Please review and merge PR #68 to resolve this issue.
Reactions are currently unavailable