forked from digma-ai/forkof-spring-petclinic
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Description
Issue Description
The MonitorService has been throwing IllegalStateException during monitoring operations, causing service instability. This needs to be fixed and the service implementation improved.
Current Behavior
- MonitorService throws IllegalStateException during monitoring
- isRunning() always returns false
- Poor thread management and error handling
- No proper state validation
Root Cause
The monitor() method was deliberately throwing exceptions and the service state management was incorrect.
Solution
PR #84 has been created to fix these issues by:
- Implementing proper state management
- Fixing isRunning() method
- Removing deliberate exception throwing
- Adding proper thread management
- Improving error handling and logging
- Adding proper documentation
Related Pull Request
PR #84 contains the implementation fixes.
Additional Notes
- The monitor() method now has a placeholder for actual monitoring logic
- Thread management has been improved with proper interrupt handling
- Added daemon thread setting for better JVM lifecycle management
Labels
- bug
- enhancement
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request