From 36d43727c546e948d3c0a38075728704f5aaa764 Mon Sep 17 00:00:00 2001 From: Michael Mendy Date: Wed, 20 May 2026 18:10:03 -0700 Subject: [PATCH 1/2] docs: clarify configure show command help Update the configure show command description to explain that it displays the effective runtime configuration stored for one model or all models. --- cmd/cli/commands/configure_show.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/cmd/cli/commands/configure_show.go b/cmd/cli/commands/configure_show.go index 15864c89f..dd6ac4b4c 100644 --- a/cmd/cli/commands/configure_show.go +++ b/cmd/cli/commands/configure_show.go @@ -5,31 +5,37 @@ import ( "fmt" "github.com/docker/model-runner/cmd/cli/commands/completion" + "github.com/spf13/cobra" ) func newConfigureShowCmd() *cobra.Command { c := &cobra.Command{ Use: "show [MODEL]", - Short: "Show model configurations", + Short: "Show effective runtime configuration for models", + Long: "Show the effective runtime configuration that Docker Model Runner has stored for one model or all models.", Args: cobra.MaximumNArgs(1), RunE: func(cmd *cobra.Command, args []string) error { var modelFilter string if len(args) > 0 { modelFilter = args[0] } + configs, err := desktopClient.ShowConfigs(modelFilter) if err != nil { return err } - jsonResult, err := json.MarshalIndent(configs, "", " ") + + jsonResult, err := json.MarshalIndent(configs, "", " ") if err != nil { return fmt.Errorf("failed to marshal configs to JSON: %w", err) } + cmd.Println(string(jsonResult)) return nil }, ValidArgsFunction: completion.ModelNames(getDesktopClient, 1), } + return c } From a6031e327c651d2adecc47e4b9af3e55c033856e Mon Sep 17 00:00:00 2001 From: Michael Mendy Date: Thu, 21 May 2026 06:35:22 -0700 Subject: [PATCH 2/2] Keep the existing two-space JSON indentation unchanged to preserve the current output format. --- cmd/cli/commands/configure_show.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/cli/commands/configure_show.go b/cmd/cli/commands/configure_show.go index dd6ac4b4c..9fa8efdca 100644 --- a/cmd/cli/commands/configure_show.go +++ b/cmd/cli/commands/configure_show.go @@ -26,7 +26,7 @@ func newConfigureShowCmd() *cobra.Command { return err } - jsonResult, err := json.MarshalIndent(configs, "", " ") + jsonResult, err := json.MarshalIndent(configs, "", " ") if err != nil { return fmt.Errorf("failed to marshal configs to JSON: %w", err) }