From b34ee76a3b7f1927c8b9ddaedc4af6e934acf873 Mon Sep 17 00:00:00 2001 From: Varya Stepanova Date: Sun, 25 May 2014 18:40:08 +0400 Subject: [PATCH 1/3] Possibility to tune disqusIdentifier --- src/services.plugin.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services.plugin.coffee b/src/services.plugin.coffee index 58e8fc4..91b3179 100644 --- a/src/services.plugin.coffee +++ b/src/services.plugin.coffee @@ -354,7 +354,7 @@ module.exports = (BasePlugin) -> return '' unless disqusShortname disqusDeveloper = if 'production' in @getEnvironments() then '0' else '1' pageUrl = @getPageUrl() - disqusIdentifier = @document.slug + disqusIdentifier = @document.disqusIdentifier || @document.slug disqusTitle = @document.title or @document.name # Return From 9905b6e78080c91900cc3d5610db53184c5ea5d3 Mon Sep 17 00:00:00 2001 From: Varya Stepanova Date: Sun, 25 May 2014 18:58:43 +0400 Subject: [PATCH 2/3] Check if undefined (empty in also possible) --- src/services.plugin.coffee | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/services.plugin.coffee b/src/services.plugin.coffee index 91b3179..c8fcb44 100644 --- a/src/services.plugin.coffee +++ b/src/services.plugin.coffee @@ -354,7 +354,10 @@ module.exports = (BasePlugin) -> return '' unless disqusShortname disqusDeveloper = if 'production' in @getEnvironments() then '0' else '1' pageUrl = @getPageUrl() - disqusIdentifier = @document.disqusIdentifier || @document.slug + if (@document.disqusIdentifier !== undefined) + disqusIdentifier = @document.disqusIdentifier + else + disqusIdentifier= @document.slug disqusTitle = @document.title or @document.name # Return From e867b5a900bf6bba4d3c59242561f50b008fa203 Mon Sep 17 00:00:00 2001 From: Varya Stepanova Date: Sun, 25 May 2014 19:03:07 +0400 Subject: [PATCH 3/3] Correct syntax of coffee --- src/services.plugin.coffee | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/services.plugin.coffee b/src/services.plugin.coffee index c8fcb44..487047a 100644 --- a/src/services.plugin.coffee +++ b/src/services.plugin.coffee @@ -354,10 +354,10 @@ module.exports = (BasePlugin) -> return '' unless disqusShortname disqusDeveloper = if 'production' in @getEnvironments() then '0' else '1' pageUrl = @getPageUrl() - if (@document.disqusIdentifier !== undefined) - disqusIdentifier = @document.disqusIdentifier - else - disqusIdentifier= @document.slug + if @document.disqusIdentifier isnt undefined + disqusIdentifier = @document.disqusIdentifier + else + disqusIdentifier = @document.slug disqusTitle = @document.title or @document.name # Return