From f8f60cab455d1c73829e725d6cd04b71a127d6bf Mon Sep 17 00:00:00 2001 From: Kenneth Chan Date: Tue, 24 Jul 2018 15:49:25 -0700 Subject: [PATCH] Apply SKIP LOCKED optimization for reserving a delayed job entry --- lib/delayed/backend/active_record.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/delayed/backend/active_record.rb b/lib/delayed/backend/active_record.rb index b69fd050..6c6f1409 100644 --- a/lib/delayed/backend/active_record.rb +++ b/lib/delayed/backend/active_record.rb @@ -125,7 +125,7 @@ def self.reserve_with_scope_using_optimized_postgres(ready_scope, worker, now) # use 'FOR UPDATE' and we would have many locking conflicts quoted_name = connection.quote_table_name(table_name) subquery = ready_scope.limit(1).lock(true).select("id").to_sql - sql = "UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery}) RETURNING *" + sql = "UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery} SKIP LOCKED) RETURNING *" reserved = find_by_sql([sql, now, worker.name]) reserved[0] end