From f968c5ce0990b90862acdf05a7f0629f9d12c663 Mon Sep 17 00:00:00 2001 From: James Cor Date: Wed, 10 Jun 2026 15:30:23 -0700 Subject: [PATCH 1/6] bump and fix tests --- go.mod | 6 +++--- go.sum | 12 ++++++------ testing/go/index_test.go | 10 +++++----- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/go.mod b/go.mod index 7ca1fcbe77..b61220d18e 100644 --- a/go.mod +++ b/go.mod @@ -6,10 +6,10 @@ require ( github.com/PuerkitoBio/goquery v1.8.1 github.com/cockroachdb/apd/v3 v3.2.3 github.com/cockroachdb/errors v1.7.5 - github.com/dolthub/dolt/go v0.40.5-0.20260609180312-20cac47c5cf9 + github.com/dolthub/dolt/go v0.40.5-0.20260610214306-07d58b65a938 github.com/dolthub/eventsapi_schema v0.0.0-20260310172945-37a9265ade69 github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 - github.com/dolthub/go-mysql-server v0.20.1-0.20260608231025-6579b6af9de2 + github.com/dolthub/go-mysql-server v0.20.1-0.20260610194023-b023be985ad3 github.com/dolthub/pg_query_go/v6 v6.0.0-20251215122834-fb20be4254d1 github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216 github.com/dolthub/vitess v0.0.0-20260604210335-0893abc80542 @@ -105,7 +105,7 @@ require ( github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12 // indirect github.com/dolthub/dolt-mcp v0.3.4 // indirect github.com/dolthub/fslock v0.0.5 // indirect - github.com/dolthub/go-icu-regex v0.0.0-20260412212219-49724d547866 // indirect + github.com/dolthub/go-icu-regex v0.0.0-20260610153742-72563bc7ca83 // indirect github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 // indirect github.com/dolthub/ishell v0.0.0-20260414231531-5f031e3e9037 // indirect github.com/dolthub/jsonpath v0.0.2-0.20240227200619-19675ab05c71 // indirect diff --git a/go.sum b/go.sum index 29b6355aa2..9ed5f1bd84 100644 --- a/go.sum +++ b/go.sum @@ -246,18 +246,18 @@ github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12 h1:I github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12/go.mod h1:rN7X8BHwkjPcfMQQ2QTAq/xM3leUSGLfb+1Js7Y6TVo= github.com/dolthub/dolt-mcp v0.3.4 h1:AyG5cw+fNWXDHXujtQnqUPZrpWtPg6FN6yYtjv1pP44= github.com/dolthub/dolt-mcp v0.3.4/go.mod h1:bCZ7KHvDYs+M0e+ySgmGiNvLhcwsN7bbf5YCyillLrk= -github.com/dolthub/dolt/go v0.40.5-0.20260609180312-20cac47c5cf9 h1:tDoj5+v3WjAT6Ospy44shBeaOhrbTcEcs6tNRaB4zxw= -github.com/dolthub/dolt/go v0.40.5-0.20260609180312-20cac47c5cf9/go.mod h1:qUI6QdFuKRbg4/7U+gNrm1dcuH3ZpCSJNgT6GnZ2fTQ= +github.com/dolthub/dolt/go v0.40.5-0.20260610214306-07d58b65a938 h1:nRmi3WXBHzRnXqsu1u6cNF7itby16qSCdO6gcWW5o2Y= +github.com/dolthub/dolt/go v0.40.5-0.20260610214306-07d58b65a938/go.mod h1:FI7xG4cWZw5vbQXrUc3Ch6r1qto9bdoLLQUuaP1Yzfo= github.com/dolthub/eventsapi_schema v0.0.0-20260310172945-37a9265ade69 h1:JShhbqMw26nKx3pqqu/cFxOpzBkN+4elVhzuUfgDw2k= github.com/dolthub/eventsapi_schema v0.0.0-20260310172945-37a9265ade69/go.mod h1:SSLraQS/jGLYFgff3vuZ+JbVUct6vyEeMzjLBqWqoyM= github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 h1:u3PMzfF8RkKd3lB9pZ2bfn0qEG+1Gms9599cr0REMww= github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2/go.mod h1:mIEZOHnFx4ZMQeawhw9rhsj+0zwQj7adVsnBX7t+eKY= github.com/dolthub/fslock v0.0.5 h1:QoXhBhgY1oumHE26qyE7tgmXUT8qjJwxsIzo54O/B/k= github.com/dolthub/fslock v0.0.5/go.mod h1:sdofYYqE0D79zNZyB4/kmlnsQOVap1C2yByjGKSirEM= -github.com/dolthub/go-icu-regex v0.0.0-20260412212219-49724d547866 h1:U6gSf5I0e6h6GP1/5Sa7D2lWW1CWfcVPtY5wkyHq6jY= -github.com/dolthub/go-icu-regex v0.0.0-20260412212219-49724d547866/go.mod h1:F3cnm+vMRK1HaU6+rNqQrOCyR03HHhR1GWG2gnPOqaE= -github.com/dolthub/go-mysql-server v0.20.1-0.20260608231025-6579b6af9de2 h1:xrRFEiifbxFFpRvNVswPFYXxg6UKgaWUW7UmFI+Z7NU= -github.com/dolthub/go-mysql-server v0.20.1-0.20260608231025-6579b6af9de2/go.mod h1:A3nEC4RgBm9UzuQCGhQhJDQAiFMPsZU3NPKbGhEd8R4= +github.com/dolthub/go-icu-regex v0.0.0-20260610153742-72563bc7ca83 h1:FEMjCGEroDnY/BXyAffVZxUpXhP2GpoUJyyq5KaLn8c= +github.com/dolthub/go-icu-regex v0.0.0-20260610153742-72563bc7ca83/go.mod h1:F3cnm+vMRK1HaU6+rNqQrOCyR03HHhR1GWG2gnPOqaE= +github.com/dolthub/go-mysql-server v0.20.1-0.20260610194023-b023be985ad3 h1:0rqYZgC8xeJkSuWtRBc64wOfro9ewjzEiQAnKBbnASA= +github.com/dolthub/go-mysql-server v0.20.1-0.20260610194023-b023be985ad3/go.mod h1:A3nEC4RgBm9UzuQCGhQhJDQAiFMPsZU3NPKbGhEd8R4= github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI= github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q= github.com/dolthub/ishell v0.0.0-20260414231531-5f031e3e9037 h1:oIW9HwuWrhxv+4HZxA+QQSKHLqWFyXZ2FmNjUYwkdiM= diff --git a/testing/go/index_test.go b/testing/go/index_test.go index e5e7c48064..f09445191b 100644 --- a/testing/go/index_test.go +++ b/testing/go/index_test.go @@ -198,7 +198,7 @@ func TestBasicIndexing(t *testing.T) { {"Sort(test.pk ASC)"}, {" └─ IndexedTableAccess(test)"}, {" ├─ index: [test.pk,test.v1]"}, - {" ├─ filters: [{[NULL, ∞), (NULL, f)}, {[NULL, ∞), (t, ∞)}]"}, + {" ├─ filters: [{(NULL, ∞), (NULL, f)}, {(NULL, ∞), (t, ∞)}]"}, {" └─ columns: [pk v1]"}, }, }, @@ -288,7 +288,7 @@ func TestBasicIndexing(t *testing.T) { {" ├─ (test.v1 = jointable.v3 AND test.v2 = 22)"}, {" ├─ IndexedTableAccess(test)"}, {" │ ├─ index: [test.pk]"}, - {" │ ├─ filters: [{[NULL, ∞)}]"}, + {" │ ├─ filters: [{(NULL, ∞)}]"}, {" │ └─ columns: [pk v1 v2]"}, {" └─ Table"}, {" ├─ name: jointable"}, @@ -308,7 +308,7 @@ func TestBasicIndexing(t *testing.T) { {" ├─ (test.v1 = jointable.v3 AND test.v2 = jointable.v4)"}, {" ├─ IndexedTableAccess(test)"}, {" │ ├─ index: [test.pk]"}, - {" │ ├─ filters: [{[NULL, ∞)}]"}, + {" │ ├─ filters: [{(NULL, ∞)}]"}, {" │ └─ columns: [pk v1 v2]"}, {" └─ Table"}, {" ├─ name: jointable"}, @@ -462,7 +462,7 @@ func TestBasicIndexing(t *testing.T) { {" ├─ (test.v1 = jointable.v3 AND test.v2 = 22)"}, {" ├─ IndexedTableAccess(test)"}, {" │ ├─ index: [test.pk]"}, - {" │ ├─ filters: [{[NULL, ∞)}]"}, + {" │ ├─ filters: [{(NULL, ∞)}]"}, {" │ └─ columns: [pk v1 v2]"}, {" └─ Table"}, {" ├─ name: jointable"}, @@ -496,7 +496,7 @@ func TestBasicIndexing(t *testing.T) { {" ├─ (test.v1 = sq.v3 AND test.v2 = sq.v4)"}, {" ├─ IndexedTableAccess(test)"}, {" │ ├─ index: [test.pk]"}, - {" │ ├─ filters: [{[NULL, ∞)}]"}, + {" │ ├─ filters: [{(NULL, ∞)}]"}, {" │ └─ columns: [pk v1 v2]"}, {" └─ TableAlias(sq)"}, {" └─ Table"}, From 6f250ede6cba71c1eeb772a158c451ca751f1091 Mon Sep 17 00:00:00 2001 From: James Cor Date: Thu, 11 Jun 2026 13:17:32 -0700 Subject: [PATCH 2/6] prevent overflow in index --- server/tables/pgcatalog/pg_constraint.go | 57 ++++++++++++------------ 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/server/tables/pgcatalog/pg_constraint.go b/server/tables/pgcatalog/pg_constraint.go index 17d3dad3d1..d4ceb31155 100644 --- a/server/tables/pgcatalog/pg_constraint.go +++ b/server/tables/pgcatalog/pg_constraint.go @@ -113,13 +113,13 @@ func (p PgConstraintHandler) PkSchema() sql.PrimaryKeySchema { // Indexes implements tables.IndexedTableHandler. func (p PgConstraintHandler) Indexes() ([]sql.Index, error) { return []sql.Index{ - pgCatalogInMemIndex{ - name: "pg_constraint_oid_index", - tblName: "pg_constraint", - dbName: "pg_catalog", - uniq: true, - columnExprs: []sql.ColumnExpressionType{{Expression: "pg_constraint.oid", Type: pgtypes.Oid}}, - }, + //pgCatalogInMemIndex{ + // name: "pg_constraint_oid_index", + // tblName: "pg_constraint", + // dbName: "pg_catalog", + // uniq: true, + // columnExprs: []sql.ColumnExpressionType{{Expression: "pg_constraint.oid", Type: pgtypes.Oid}}, + //}, pgCatalogInMemIndex{ name: "pg_constraint_conrelid_contypid_conname_index", tblName: "pg_constraint", @@ -131,27 +131,27 @@ func (p PgConstraintHandler) Indexes() ([]sql.Index, error) { {Expression: "pg_constraint.conname", Type: pgtypes.Name}, }, }, - pgCatalogInMemIndex{ - name: "pg_constraint_conname_nsp_index", - tblName: "pg_constraint", - dbName: "pg_catalog", - uniq: false, - columnExprs: []sql.ColumnExpressionType{ - {Expression: "pg_constraint.conname", Type: pgtypes.Name}, - {Expression: "pg_constraint.connamespace", Type: pgtypes.Oid}, - }, - }, + //pgCatalogInMemIndex{ + // name: "pg_constraint_conname_nsp_index", + // tblName: "pg_constraint", + // dbName: "pg_catalog", + // uniq: false, + // columnExprs: []sql.ColumnExpressionType{ + // {Expression: "pg_constraint.conname", Type: pgtypes.Name}, + // {Expression: "pg_constraint.connamespace", Type: pgtypes.Oid}, + // }, + //}, // pg_constraint_conparentid_index is skipped because we don't support partitions, but might be worth // implementing if it makes any tool faster - pgCatalogInMemIndex{ - name: "pg_constraint_contypid_index", - tblName: "pg_constraint", - dbName: "pg_catalog", - uniq: false, - columnExprs: []sql.ColumnExpressionType{ - {Expression: "pg_constraint.contypid", Type: pgtypes.Oid}, - }, - }, + //pgCatalogInMemIndex{ + // name: "pg_constraint_contypid_index", + // tblName: "pg_constraint", + // dbName: "pg_catalog", + // uniq: false, + // columnExprs: []sql.ColumnExpressionType{ + // {Expression: "pg_constraint.contypid", Type: pgtypes.Oid}, + // }, + //}, }, nil } @@ -274,15 +274,16 @@ func (p PgConstraintHandler) getIndexScanRange(rng sql.Range, index sql.Index) ( } if hasUpperBound { + // TODO: does this make sense? // our less-than upper bounds depend on how many fields were set if typOidUpperSet { if nameUpperSet { nameUpper = fmt.Sprintf("%s%o", nameUpper, rune(0)) - } else { + } else if typOidUpper < math.MaxUint32 { // prevent overflow typOidUpper = typOidUpper + 1 } } else { - if !relOidUpperSet { + if !relOidUpperSet && relOidUpper < math.MaxUint32 { // prevent overflow relOidUpper = relOidUpper + 1 } } From 3e63bdca6c4c92394302704cc9c424a1f4a0b0ab Mon Sep 17 00:00:00 2001 From: James Cor Date: Thu, 11 Jun 2026 13:20:48 -0700 Subject: [PATCH 3/6] bump --- go.mod | 4 ++-- go.sum | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/go.mod b/go.mod index b61220d18e..4ed38896df 100644 --- a/go.mod +++ b/go.mod @@ -6,10 +6,10 @@ require ( github.com/PuerkitoBio/goquery v1.8.1 github.com/cockroachdb/apd/v3 v3.2.3 github.com/cockroachdb/errors v1.7.5 - github.com/dolthub/dolt/go v0.40.5-0.20260610214306-07d58b65a938 + github.com/dolthub/dolt/go v0.40.5-0.20260611201749-2de22d2c05da github.com/dolthub/eventsapi_schema v0.0.0-20260310172945-37a9265ade69 github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 - github.com/dolthub/go-mysql-server v0.20.1-0.20260610194023-b023be985ad3 + github.com/dolthub/go-mysql-server v0.20.1-0.20260610222239-82ca9a426101 github.com/dolthub/pg_query_go/v6 v6.0.0-20251215122834-fb20be4254d1 github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216 github.com/dolthub/vitess v0.0.0-20260604210335-0893abc80542 diff --git a/go.sum b/go.sum index 9ed5f1bd84..988715ed93 100644 --- a/go.sum +++ b/go.sum @@ -246,8 +246,8 @@ github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12 h1:I github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12/go.mod h1:rN7X8BHwkjPcfMQQ2QTAq/xM3leUSGLfb+1Js7Y6TVo= github.com/dolthub/dolt-mcp v0.3.4 h1:AyG5cw+fNWXDHXujtQnqUPZrpWtPg6FN6yYtjv1pP44= github.com/dolthub/dolt-mcp v0.3.4/go.mod h1:bCZ7KHvDYs+M0e+ySgmGiNvLhcwsN7bbf5YCyillLrk= -github.com/dolthub/dolt/go v0.40.5-0.20260610214306-07d58b65a938 h1:nRmi3WXBHzRnXqsu1u6cNF7itby16qSCdO6gcWW5o2Y= -github.com/dolthub/dolt/go v0.40.5-0.20260610214306-07d58b65a938/go.mod h1:FI7xG4cWZw5vbQXrUc3Ch6r1qto9bdoLLQUuaP1Yzfo= +github.com/dolthub/dolt/go v0.40.5-0.20260611201749-2de22d2c05da h1:zYDtpzy7/HFxOzr8KHGhBtKfiYmx6g8yYZCgslIPuys= +github.com/dolthub/dolt/go v0.40.5-0.20260611201749-2de22d2c05da/go.mod h1:6K1zrTpiNo4fyzyZA71LXHCrgt1tWY8QC6aRoCe9WlA= github.com/dolthub/eventsapi_schema v0.0.0-20260310172945-37a9265ade69 h1:JShhbqMw26nKx3pqqu/cFxOpzBkN+4elVhzuUfgDw2k= github.com/dolthub/eventsapi_schema v0.0.0-20260310172945-37a9265ade69/go.mod h1:SSLraQS/jGLYFgff3vuZ+JbVUct6vyEeMzjLBqWqoyM= github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 h1:u3PMzfF8RkKd3lB9pZ2bfn0qEG+1Gms9599cr0REMww= @@ -256,8 +256,8 @@ github.com/dolthub/fslock v0.0.5 h1:QoXhBhgY1oumHE26qyE7tgmXUT8qjJwxsIzo54O/B/k= github.com/dolthub/fslock v0.0.5/go.mod h1:sdofYYqE0D79zNZyB4/kmlnsQOVap1C2yByjGKSirEM= github.com/dolthub/go-icu-regex v0.0.0-20260610153742-72563bc7ca83 h1:FEMjCGEroDnY/BXyAffVZxUpXhP2GpoUJyyq5KaLn8c= github.com/dolthub/go-icu-regex v0.0.0-20260610153742-72563bc7ca83/go.mod h1:F3cnm+vMRK1HaU6+rNqQrOCyR03HHhR1GWG2gnPOqaE= -github.com/dolthub/go-mysql-server v0.20.1-0.20260610194023-b023be985ad3 h1:0rqYZgC8xeJkSuWtRBc64wOfro9ewjzEiQAnKBbnASA= -github.com/dolthub/go-mysql-server v0.20.1-0.20260610194023-b023be985ad3/go.mod h1:A3nEC4RgBm9UzuQCGhQhJDQAiFMPsZU3NPKbGhEd8R4= +github.com/dolthub/go-mysql-server v0.20.1-0.20260610222239-82ca9a426101 h1:Abci4YqSTb0jRO7H/BGljkSJ0hkAZvZlim74JLAWros= +github.com/dolthub/go-mysql-server v0.20.1-0.20260610222239-82ca9a426101/go.mod h1:xrwqyZnkLeqNm/LNp57NB+otApMXv1UJohn9dSkbgR0= github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI= github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q= github.com/dolthub/ishell v0.0.0-20260414231531-5f031e3e9037 h1:oIW9HwuWrhxv+4HZxA+QQSKHLqWFyXZ2FmNjUYwkdiM= From 6ea696d5dbfa53cfaccb6eaed0604ed22ee08b59 Mon Sep 17 00:00:00 2001 From: James Cor Date: Thu, 11 Jun 2026 13:21:59 -0700 Subject: [PATCH 4/6] uncomment --- server/tables/pgcatalog/pg_constraint.go | 56 ++++++++++++------------ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/server/tables/pgcatalog/pg_constraint.go b/server/tables/pgcatalog/pg_constraint.go index d4ceb31155..27aae85806 100644 --- a/server/tables/pgcatalog/pg_constraint.go +++ b/server/tables/pgcatalog/pg_constraint.go @@ -113,13 +113,13 @@ func (p PgConstraintHandler) PkSchema() sql.PrimaryKeySchema { // Indexes implements tables.IndexedTableHandler. func (p PgConstraintHandler) Indexes() ([]sql.Index, error) { return []sql.Index{ - //pgCatalogInMemIndex{ - // name: "pg_constraint_oid_index", - // tblName: "pg_constraint", - // dbName: "pg_catalog", - // uniq: true, - // columnExprs: []sql.ColumnExpressionType{{Expression: "pg_constraint.oid", Type: pgtypes.Oid}}, - //}, + pgCatalogInMemIndex{ + name: "pg_constraint_oid_index", + tblName: "pg_constraint", + dbName: "pg_catalog", + uniq: true, + columnExprs: []sql.ColumnExpressionType{{Expression: "pg_constraint.oid", Type: pgtypes.Oid}}, + }, pgCatalogInMemIndex{ name: "pg_constraint_conrelid_contypid_conname_index", tblName: "pg_constraint", @@ -131,27 +131,27 @@ func (p PgConstraintHandler) Indexes() ([]sql.Index, error) { {Expression: "pg_constraint.conname", Type: pgtypes.Name}, }, }, - //pgCatalogInMemIndex{ - // name: "pg_constraint_conname_nsp_index", - // tblName: "pg_constraint", - // dbName: "pg_catalog", - // uniq: false, - // columnExprs: []sql.ColumnExpressionType{ - // {Expression: "pg_constraint.conname", Type: pgtypes.Name}, - // {Expression: "pg_constraint.connamespace", Type: pgtypes.Oid}, - // }, - //}, - // pg_constraint_conparentid_index is skipped because we don't support partitions, but might be worth - // implementing if it makes any tool faster - //pgCatalogInMemIndex{ - // name: "pg_constraint_contypid_index", - // tblName: "pg_constraint", - // dbName: "pg_catalog", - // uniq: false, - // columnExprs: []sql.ColumnExpressionType{ - // {Expression: "pg_constraint.contypid", Type: pgtypes.Oid}, - // }, - //}, + pgCatalogInMemIndex{ + name: "pg_constraint_conname_nsp_index", + tblName: "pg_constraint", + dbName: "pg_catalog", + uniq: false, + columnExprs: []sql.ColumnExpressionType{ + {Expression: "pg_constraint.conname", Type: pgtypes.Name}, + {Expression: "pg_constraint.connamespace", Type: pgtypes.Oid}, + }, + }, + //pg_constraint_conparentid_index is skipped because we don't support partitions, but might be worth + //implementing if it makes any tool faster + pgCatalogInMemIndex{ + name: "pg_constraint_contypid_index", + tblName: "pg_constraint", + dbName: "pg_catalog", + uniq: false, + columnExprs: []sql.ColumnExpressionType{ + {Expression: "pg_constraint.contypid", Type: pgtypes.Oid}, + }, + }, }, nil } From 1be39de138f61dccd8f7629a2772916d2f8adbc6 Mon Sep 17 00:00:00 2001 From: James Cor Date: Thu, 11 Jun 2026 13:22:26 -0700 Subject: [PATCH 5/6] asdf --- server/tables/pgcatalog/pg_constraint.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/tables/pgcatalog/pg_constraint.go b/server/tables/pgcatalog/pg_constraint.go index 27aae85806..bfced145fa 100644 --- a/server/tables/pgcatalog/pg_constraint.go +++ b/server/tables/pgcatalog/pg_constraint.go @@ -141,8 +141,8 @@ func (p PgConstraintHandler) Indexes() ([]sql.Index, error) { {Expression: "pg_constraint.connamespace", Type: pgtypes.Oid}, }, }, - //pg_constraint_conparentid_index is skipped because we don't support partitions, but might be worth - //implementing if it makes any tool faster + // pg_constraint_conparentid_index is skipped because we don't support partitions, but might be worth + // implementing if it makes any tool faster pgCatalogInMemIndex{ name: "pg_constraint_contypid_index", tblName: "pg_constraint", From dcb651870f33dc4f84087a9b5e1554a5a6692af1 Mon Sep 17 00:00:00 2001 From: James Cor Date: Thu, 11 Jun 2026 13:22:55 -0700 Subject: [PATCH 6/6] remove todo --- server/tables/pgcatalog/pg_constraint.go | 1 - 1 file changed, 1 deletion(-) diff --git a/server/tables/pgcatalog/pg_constraint.go b/server/tables/pgcatalog/pg_constraint.go index bfced145fa..a9b2bd7d48 100644 --- a/server/tables/pgcatalog/pg_constraint.go +++ b/server/tables/pgcatalog/pg_constraint.go @@ -274,7 +274,6 @@ func (p PgConstraintHandler) getIndexScanRange(rng sql.Range, index sql.Index) ( } if hasUpperBound { - // TODO: does this make sense? // our less-than upper bounds depend on how many fields were set if typOidUpperSet { if nameUpperSet {