From 27bea6e4b99e72999329b6994eec5969ad3aa61e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E7=83=AD=E5=BF=83=E5=B8=82=E6=B0=91=E7=9F=B3=E5=85=88?=
 =?UTF-8?q?=E7=94=9F?= <1249467256@qq.com>
Date: Sun, 22 Mar 2026 00:03:15 +0800
Subject: [PATCH] Fix: Apply CachedTabControl to MainWindow and fix dark theme
 inheritance

Applies the newly created `CachedTabControl` to the `MainWindow`, replacing the native `TabControl`. This completes the implementation of visual tree caching for editor tabs, ensuring that UI states (such as scroll position and active selections) are preserved when switching between documents, while fully retaining the application's native drag-and-drop events and context menus.

**Technical Rationale (Why this approach?):**
* **Why an explicit `ControlTemplate` override?** When subclassing WPF controls like `TabControl`, the framework often drops the implicit styles applied to the base class, which can lead to a completely blank UI or rendering crashes. By explicitly defining the `ControlTemplate` and strictly setting `TargetType="{x:Type views:CachedTabControl}"`, we force the WPF rendering engine to correctly construct the visual tree for our custom caching container (`PART_ItemsHolder`).
* **Why bind to `TabItem.Static.Background`?** WPF's default UI virtualization destroys and recreates visual elements on tab switch. Since our `CachedTabControl` overrides this by keeping all elements in memory and merely toggling `Visibility.Collapsed`, relying on default system brushes can cause severe theme tearing or blinding white backgrounds when tabs lose focus. By explicitly routing the `Background` and `BorderBrush` properties to `{DynamicResource TabItem.Static.Background}` and `{DynamicResource App.Border}`, we guarantee that our cached container strictly inherits AssetEditor's custom Dark Theme dictionaries, completely bypassing WPF's native theme disconnects.
---
 AssetEditor/Views/MainWindow.xaml | 92 +++++++++++++++++--------------
 1 file changed, 51 insertions(+), 41 deletions(-)

diff --git a/AssetEditor/Views/MainWindow.xaml b/AssetEditor/Views/MainWindow.xaml
index 2f657c76..58cc7cb3 100644
--- a/AssetEditor/Views/MainWindow.xaml
+++ b/AssetEditor/Views/MainWindow.xaml
@@ -158,28 +158,54 @@
                 <GridSplitter Grid.Row="1" Grid.RowSpan="1" Grid.Column="1" Width="2.9" HorizontalAlignment="Stretch" Background="{DynamicResource App.Border}" 
                               Visibility="{Binding IsPackFileExplorerVisible, Converter={StaticResource BoolToVisibilityConverter}}"/>
 
-                <TabControl Grid.Row="1" Grid.Column="2" ItemsSource="{Binding EditorManager.CurrentEditorsList, UpdateSourceTrigger=PropertyChanged}" 
+                <views:CachedTabControl Grid.Row="1" Grid.Column="2" ItemsSource="{Binding EditorManager.CurrentEditorsList, UpdateSourceTrigger=PropertyChanged}" 
                         SelectedIndex="{Binding EditorManager.SelectedEditorIndex, UpdateSourceTrigger=PropertyChanged, Mode=TwoWay}" 
                         ContentTemplateSelector="{StaticResource EditorSelector}" viewFactory:ToolFactoryParameter.ViewFactory="{Binding ToolsFactory}"
-                        Name="EditorsTabControl" BorderThickness="1, 1, 0, 0" >
+                        x:Name="EditorsTabControl" BorderThickness="1, 1, 0, 0" >
 
-                <TabControl.Resources>
-                    <common:BindingProxy x:Key="Proxy" Data="{Binding}" />
-                </TabControl.Resources>
+                    <views:CachedTabControl.Template>
+                        <!-- [Crucial Fix]: TargetType must be strictly set to views:CachedTabControl to prevent rendering crashes or white screens -->
+                        <ControlTemplate TargetType="{x:Type views:CachedTabControl}">
+                            <Grid KeyboardNavigation.TabNavigation="Local">
+                                <Grid.RowDefinitions>
+                                    <RowDefinition Height="Auto"/>
+                                    <RowDefinition Height="*"/>
+                                </Grid.RowDefinitions>
 
-                <TabControl.ItemContainerStyle>
-                    <Style TargetType="TabItem" BasedOn="{StaticResource {x:Type TabItem}}">
-                        <EventSetter Event="Drop" Handler="TabItem_Drop"/>
-                        <EventSetter Event="PreviewMouseMove" Handler="TabItem_MouseMove"/>
-                        <EventSetter Event="PreviewMouseDown" Handler="TabItem_MouseDown"/>
-                        <Setter Property="AllowDrop" Value="True"/>
-                        <Setter Property="Focusable" Value="False"/>
-                        <Setter Property="behaviors:MouseMiddleClick.Command" Value="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolCommand}"/>
-                        <Setter Property="behaviors:MouseMiddleClick.CommandParameter" Value="{Binding}"/>
-                    </Style>
-                </TabControl.ItemContainerStyle>
+                                <!-- This line controls the display of the tab headers -->
+                                <TabPanel x:Name="HeaderPanel" Panel.ZIndex="1" Margin="0,2,2,0" IsItemsHost="True" KeyboardNavigation.TabIndex="1" Background="Transparent" />
 
-                    <TabControl.ItemTemplate>
+                                <!-- [Crucial Fix]: This binds to the AssetEditor exclusive dark theme color TabItem.Static.Background -->
+                                <Border x:Name="Border" Grid.Row="1" 
+                                        BorderThickness="{TemplateBinding BorderThickness}" 
+                                        BorderBrush="{DynamicResource App.Border}" 
+                                        Background="{DynamicResource TabItem.Static.Background}" 
+                                        KeyboardNavigation.DirectionalNavigation="Contained" 
+                                        KeyboardNavigation.TabIndex="2">
+                                    <Grid x:Name="PART_ItemsHolder" />
+                                </Border>
+                            </Grid>
+                        </ControlTemplate>
+                    </views:CachedTabControl.Template>
+
+                    <views:CachedTabControl.Resources>
+                        <common:BindingProxy x:Key="Proxy" Data="{Binding}" />
+                    </views:CachedTabControl.Resources>
+
+                    <views:CachedTabControl.ItemContainerStyle>
+                        <!-- Ensure each child tab item inherits the native theme and events -->
+                        <Style TargetType="TabItem" BasedOn="{StaticResource {x:Type TabItem}}">
+                            <EventSetter Event="Drop" Handler="TabItem_Drop"/>
+                            <EventSetter Event="PreviewMouseMove" Handler="TabItem_MouseMove"/>
+                            <EventSetter Event="PreviewMouseDown" Handler="TabItem_MouseDown"/>
+                            <Setter Property="AllowDrop" Value="True"/>
+                            <Setter Property="Focusable" Value="False"/>
+                            <Setter Property="behaviors:MouseMiddleClick.Command" Value="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolCommand}"/>
+                            <Setter Property="behaviors:MouseMiddleClick.CommandParameter" Value="{Binding}"/>
+                        </Style>
+                    </views:CachedTabControl.ItemContainerStyle>
+
+                    <views:CachedTabControl.ItemTemplate>
                         <DataTemplate>
                             <Grid>
                                 <Grid.Resources>
@@ -193,22 +219,12 @@
 
                                 <Grid.ContextMenu>
                                     <ContextMenu>
-                                        <MenuItem Header="Close"
-                                            Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolCommand}"
-                                            CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}" />
+                                        <MenuItem Header="Close" Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolCommand}" CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}" />
                                         <MenuItem Header="Close Multiple">
-                                            <MenuItem Header="Close Other Tabs"
-                                                Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseOtherToolsCommand}"
-                                                CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
-                                            <MenuItem Header="Close All Tabs"
-                                                Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseAllToolsCommand}"
-                                                CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
-                                            <MenuItem Header="Close Tabs To Left"
-                                                Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolsToLeftCommand}"
-                                                CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
-                                            <MenuItem Header="Close Tabs To Right"
-                                                Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolsToRightCommand}"
-                                                CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
+                                            <MenuItem Header="Close Other Tabs" Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseOtherToolsCommand}" CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
+                                            <MenuItem Header="Close All Tabs" Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseAllToolsCommand}" CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
+                                            <MenuItem Header="Close Tabs To Left" Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolsToLeftCommand}" CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
+                                            <MenuItem Header="Close Tabs To Right" Command="{Binding Source={StaticResource Proxy}, Path=Data.CloseToolsToRightCommand}" CommandParameter="{Binding Source={StaticResource GridProxy}, Path=Data}"/>
                                         </MenuItem>
                                     </ContextMenu>
                                 </Grid.ContextMenu>
@@ -224,18 +240,12 @@
                                         </Style>
                                     </TextBlock.Style>
                                 </TextBlock>
-                                <Button
-                                    Margin="4,0,-4,0"  
-                                    Grid.Column="1" 
-                                    Command="{Binding DataContext.CloseToolCommand, RelativeSource={RelativeSource FindAncestor, AncestorType=TabControl}}" 
-                                    CommandParameter="{Binding}"
-                                    HorizontalContentAlignment="Right"
-                                    Content="{materialIcons:MaterialIconExt Kind=CloseThick, Size=13 }">
+                                <Button Margin="4,0,-4,0" Grid.Column="1" Command="{Binding DataContext.CloseToolCommand, RelativeSource={RelativeSource FindAncestor, AncestorType=TabControl}}" CommandParameter="{Binding}" HorizontalContentAlignment="Right" Content="{materialIcons:MaterialIconExt Kind=CloseThick, Size=13 }">
                                 </Button>
                             </Grid>
                         </DataTemplate>
-                    </TabControl.ItemTemplate>
-                </TabControl>
+                    </views:CachedTabControl.ItemTemplate>
+                </views:CachedTabControl>
             </Grid>
         </Border>