How to use readts; error `Maximum call stack size exceeded`

[Kamirus]

Hi, I wanted to get a TSType out of Badge.d.ts mui component. I've looked at how it is done in purescript-react-mui.

When I call readInterfaceTypes on config that includes only Badge.d.ts I get an error:

RangeError: Maximum call stack size exceeded
    ...

It looks like there is an infinite recursion between getTSType and getWithAliasProps.

When I restricted the function argument for readInterfaceTypes so that it returns true only for "BadgeProps" and removed some fields (children, badgeContent, component) it terminated without the error.

I've added simple recursive type as an additional field in the interface and Maximum call stack size exceeded again

Am I doing something wrong?
Just for the record, I've cloned the purescript-react-mui installed it and built, but running the /synctypes caused the same error 😞

[paluh]

@doolse because we were in hurry and using ts compiler API from javascript is not funny we had decided to rewrite this library: https://github.com/lambdaterms/purescript-read-dts . Of course we are really open for possibility to merge our fork into your library somehow :-)

This are current main differences:

• FFI is written in typescript and extended in many places.

• AST type is recursive and we are processing it using recursion schemes.

• We have provided separate type to handle fully instantiated types. We have simple, incomplete AST instantiation transformation, but we think that we won't go this direction any further...

Because some pieces of our FFI are loosely inspired by your code we had some problems with deciding how to license our work. Currently we have licensed our code under BSD license and listed you as a co-author. Of course we are really open and we can change this approach if you want to. Please let us know.

Please let me know what do you think about these changes.

[doolse]

@doolse because we were in hurry and using ts compiler API from javascript is not funny we had decided to rewrite this library: https://github.com/lambdaterms/purescript-read-dts . Of course we are really open for possibility to merge our fork into your library somehow :-)

This are current main differences:

• FFI is written in typescript and extended in many places.
• AST type is recursive and we are processing it using recursion schemes.
• We have provided separate type to handle fully instantiated types. We have simple, incomplete AST instantiation transformation, but we think that we won't go this direction any further...

Because some pieces of our FFI are loosely inspired by your code we had some problems with deciding how to license our work. Currently we have licensed our code under BSD license and listed you as a co-author. Of course we are really open and we can change this approach if you want to. Please let us know.

Please let me know what do you think about these changes.

Sorry for being so unresponsive, as you can probably guess I don't have a lot of spare time for this project at the moment. I've added the MIT license now, so feel free to do as you please. BTW what are you using it for? Material UI? Any luck with the 4.x series?

[paluh]

• BTW what are you using it for? Material UI? Any luck with the 4.x series?

Yeah, we are currently focusing on MUI but want to finally extract some more general t2p library. Strategy which just starting to work for us is shortly described here:

https://github.com/lambdaterms-forks/purescript-react-basic-mui/blob/codegen-read-dts/codegen/src/TS/Module.purs#L3

We have on PS level a ReadDTS.AST which is built with unfold on the PS level (FFI API started as a fork of your FFI and its original shape has been preserved). Then we try to instantiate it to ReadDTS.Instantiation.Type which then we turn into Codegen.AST ("inspired" by purescript-cst) and final codegen.

Here is an example module representation which we pass to codegen:

https://github.com/lambdaterms-forks/purescript-react-basic-mui/blob/codegen-read-dts/codegen/src/Main.purs#L86

and here is the final module generated from it:

https://github.com/lambdaterms-forks/purescript-react-basic-mui/blob/codegen-read-dts/src/MUI/Core/Badge.purs

Regarding code formatting we want to probably incorporate purty into build chain (or just commit hook) and not bother with any pprint implementation.