From a905e8f051df2829bcc03e2d1aef043b0148b436 Mon Sep 17 00:00:00 2001 From: EduardF1 <50618110+EduardF1@users.noreply.github.com> Date: Thu, 30 Apr 2026 00:19:32 +0200 Subject: [PATCH 1/2] feat: add [StringSyntax(DateTimeFormat)] to DateTimeOffset methods in BindConverter The previous PR (commit f036ca8) added StringSyntax annotations to DateTime, DateOnly, and TimeOnly methods but missed the equivalent DateTimeOffset overloads. This commit fixes that omission. Fixes #44535 (partially) --- src/Components/Components/src/BindConverter.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Components/Components/src/BindConverter.cs b/src/Components/Components/src/BindConverter.cs index d4971de515d3..a70d06d0d1d7 100644 --- a/src/Components/Components/src/BindConverter.cs +++ b/src/Components/Components/src/BindConverter.cs @@ -422,7 +422,7 @@ private static string FormatDateTimeValueCore(DateTime value, CultureInfo? cultu /// /// The formatted value. [SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Required to maintain compatibility")] - public static string FormatValue(DateTimeOffset value, string format, CultureInfo? culture = null) => FormatDateTimeOffsetValueCore(value, format, culture); + public static string FormatValue(DateTimeOffset value, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, CultureInfo? culture = null) => FormatDateTimeOffsetValueCore(value, format, culture); private static string FormatDateTimeOffsetValueCore(DateTimeOffset value, string? format, CultureInfo? culture) { @@ -460,7 +460,7 @@ private static string FormatDateTimeOffsetValueCore(DateTimeOffset value, Cultur /// /// The formatted value. [SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Required to maintain compatibility")] - public static string? FormatValue(DateTimeOffset? value, string format, CultureInfo? culture = null) => FormatNullableDateTimeOffsetValueCore(value, format, culture); + public static string? FormatValue(DateTimeOffset? value, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, CultureInfo? culture = null) => FormatNullableDateTimeOffsetValueCore(value, format, culture); private static string? FormatNullableDateTimeOffsetValueCore(DateTimeOffset? value, string? format, CultureInfo? culture) { @@ -1297,7 +1297,7 @@ public static bool TryConvertToDateTimeOffset(object? obj, CultureInfo? culture, /// The format string to use in conversion. /// The converted value. /// true if conversion is successful, otherwise false. - public static bool TryConvertToDateTimeOffset(object? obj, CultureInfo? culture, string format, out DateTimeOffset value) + public static bool TryConvertToDateTimeOffset(object? obj, CultureInfo? culture, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, out DateTimeOffset value) { return ConvertToDateTimeOffsetCore(obj, culture, format, out value); } @@ -1322,7 +1322,7 @@ public static bool TryConvertToNullableDateTimeOffset(object? obj, CultureInfo? /// The format string to use in conversion. /// The converted value. /// true if conversion is successful, otherwise false. - public static bool TryConvertToNullableDateTimeOffset(object? obj, CultureInfo? culture, string format, out DateTimeOffset? value) + public static bool TryConvertToNullableDateTimeOffset(object? obj, CultureInfo? culture, [StringSyntax(StringSyntaxAttribute.DateTimeFormat)] string format, out DateTimeOffset? value) { return ConvertToNullableDateTimeOffsetCore(obj, culture, format, out value); } From 52e3d6509c05b96bac1632766fe69b1efabe5c2c Mon Sep 17 00:00:00 2001 From: EduardF1 <50618110+EduardF1@users.noreply.github.com> Date: Sat, 9 May 2026 13:33:13 +0200 Subject: [PATCH 2/2] ci: retrigger pipelines