diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpstan.neon index 2ebef00e4..2787c4607 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/phpstan.neon @@ -30,8 +30,18 @@ parameters: treatPhpDocTypesAsCertain: false ignoreErrors: - - - # Since tests and data providers do not have to have parameter docblocks, + - # Hook implementations do not provide full type information for + # parameters or return values in iterable type arrays. + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* + - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: + - web/sites/default/includes + reportUnmatched: false + - # Since tests and data providers do not have to have parameter docblocks, # it is not possible to specify the type of the parameter, so we ignore # this error. message: '#.*no value type specified in iterable type array.#' @@ -40,17 +50,3 @@ parameters: - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - - # Hook implementations do not provide docblocks for parameters, so there - # is no way to provide this information. - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* - - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. - message: '#Variable .* might not be defined.#' - paths: - - web/sites/default/includes - reportUnmatched: false diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpstan.neon index 480532995..0c09f025d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpstan.neon @@ -13,30 +13,29 @@ - tests excludePaths: -@@ -36,8 +36,8 @@ - # this error. - message: '#.*no value type specified in iterable type array.#' - paths: -- - web/modules/custom/*/tests/* -- - web/themes/custom/*/tests/* -+ - docroot/modules/custom/*/tests/* -+ - docroot/themes/custom/*/tests/* - - tests/phpunit/* - reportUnmatched: false - - -@@ -45,12 +45,12 @@ - # is no way to provide this information. - message: '#.* with no value type specified in iterable type array#' +@@ -34,12 +34,12 @@ + # parameters or return values in iterable type arrays. + message: '#.*no value type specified in iterable type array#' paths: - - web/modules/custom/* - - web/themes/custom/* + - docroot/modules/custom/* + - docroot/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. + - # Included settings files are not aware about global variables. message: '#Variable .* might not be defined.#' paths: - - web/sites/default/includes + - docroot/sites/default/includes reportUnmatched: false + - # Since tests and data providers do not have to have parameter docblocks, + # it is not possible to specify the type of the parameter, so we ignore +@@ -46,7 +46,7 @@ + # this error. + message: '#.*no value type specified in iterable type array.#' + paths: +- - web/modules/custom/*/tests/* +- - web/themes/custom/*/tests/* ++ - docroot/modules/custom/*/tests/* ++ - docroot/themes/custom/*/tests/* + - tests/phpunit/* + reportUnmatched: false diff --git a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpstan.neon index 480532995..0c09f025d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpstan.neon @@ -13,30 +13,29 @@ - tests excludePaths: -@@ -36,8 +36,8 @@ - # this error. - message: '#.*no value type specified in iterable type array.#' - paths: -- - web/modules/custom/*/tests/* -- - web/themes/custom/*/tests/* -+ - docroot/modules/custom/*/tests/* -+ - docroot/themes/custom/*/tests/* - - tests/phpunit/* - reportUnmatched: false - - -@@ -45,12 +45,12 @@ - # is no way to provide this information. - message: '#.* with no value type specified in iterable type array#' +@@ -34,12 +34,12 @@ + # parameters or return values in iterable type arrays. + message: '#.*no value type specified in iterable type array#' paths: - - web/modules/custom/* - - web/themes/custom/* + - docroot/modules/custom/* + - docroot/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. + - # Included settings files are not aware about global variables. message: '#Variable .* might not be defined.#' paths: - - web/sites/default/includes + - docroot/sites/default/includes reportUnmatched: false + - # Since tests and data providers do not have to have parameter docblocks, + # it is not possible to specify the type of the parameter, so we ignore +@@ -46,7 +46,7 @@ + # this error. + message: '#.*no value type specified in iterable type array.#' + paths: +- - web/modules/custom/*/tests/* +- - web/themes/custom/*/tests/* ++ - docroot/modules/custom/*/tests/* ++ - docroot/themes/custom/*/tests/* + - tests/phpunit/* + reportUnmatched: false diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_claro/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/theme_stark/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpstan.neon index 9245e8fa5..88f89ad9f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpstan.neon @@ -1,8 +1,6 @@ -@@ -38,7 +38,6 @@ +@@ -48,5 +48,4 @@ paths: - web/modules/custom/*/tests/* - web/themes/custom/*/tests/* - - tests/phpunit/* reportUnmatched: false - - - # Hook implementations do not provide docblocks for parameters, so there diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpstan.neon index 9245e8fa5..88f89ad9f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpstan.neon @@ -1,8 +1,6 @@ -@@ -38,7 +38,6 @@ +@@ -48,5 +48,4 @@ paths: - web/modules/custom/*/tests/* - web/themes/custom/*/tests/* - - tests/phpunit/* reportUnmatched: false - - - # Hook implementations do not provide docblocks for parameters, so there diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/web/modules/custom/sw_demo/js/-sw_demo.test.js b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/web/modules/custom/sw_demo/js/-sw_demo.test.js deleted file mode 100644 index e69de29bb..000000000 diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/phpstan.neon index 9245e8fa5..88f89ad9f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/phpstan.neon @@ -1,8 +1,6 @@ -@@ -38,7 +38,6 @@ +@@ -48,5 +48,4 @@ paths: - web/modules/custom/*/tests/* - web/themes/custom/*/tests/* - - tests/phpunit/* reportUnmatched: false - - - # Hook implementations do not provide docblocks for parameters, so there diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/phpstan.neon index 9245e8fa5..88f89ad9f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/phpstan.neon @@ -1,8 +1,6 @@ -@@ -38,7 +38,6 @@ +@@ -48,5 +48,4 @@ paths: - web/modules/custom/*/tests/* - web/themes/custom/*/tests/* - - tests/phpunit/* reportUnmatched: false - - - # Hook implementations do not provide docblocks for parameters, so there diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpstan.neon b/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpstan.neon index 18a7b3d6e..43d4b8b5d 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpstan.neon +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpstan.neon @@ -6,19 +6,18 @@ - web/sites/default/settings.php - web/sites/default/includes - tests -@@ -37,7 +36,6 @@ +@@ -35,7 +34,6 @@ + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* +- - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: +@@ -47,6 +45,5 @@ message: '#.*no value type specified in iterable type array.#' paths: - web/modules/custom/*/tests/* - - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - -@@ -46,7 +44,6 @@ - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* -- - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. diff --git a/phpstan.neon b/phpstan.neon index e95ef2dd1..94dd210af 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -30,8 +30,18 @@ parameters: treatPhpDocTypesAsCertain: false ignoreErrors: - - - # Since tests and data providers do not have to have parameter docblocks, + - # Hook implementations do not provide full type information for + # parameters or return values in iterable type arrays. + message: '#.*no value type specified in iterable type array#' + paths: + - web/modules/custom/* + - web/themes/custom/* + - # Included settings files are not aware about global variables. + message: '#Variable .* might not be defined.#' + paths: + - web/sites/default/includes + reportUnmatched: false + - # Since tests and data providers do not have to have parameter docblocks, # it is not possible to specify the type of the parameter, so we ignore # this error. message: '#.*no value type specified in iterable type array.#' @@ -40,17 +50,3 @@ parameters: - web/themes/custom/*/tests/* - tests/phpunit/* reportUnmatched: false - - - # Hook implementations do not provide docblocks for parameters, so there - # is no way to provide this information. - message: '#.* with no value type specified in iterable type array#' - paths: - - web/modules/custom/* - - web/themes/custom/* - reportUnmatched: false - - - # Included settings files are not aware about global variables. - message: '#Variable .* might not be defined.#' - paths: - - web/sites/default/includes - reportUnmatched: false