Skip to content

Rider 4's Via Expugnatio timer leak #71

@gelguy

Description

@gelguy

Timers:CreateTimer("chariot_dash_damage", {
endTime = 0.0,
callback = function()
CreateLightningField(keys, caster:GetAbsOrigin())
local targets = FindUnitsInRadius(caster:GetTeam(), caster:GetAbsOrigin(), nil, 400, DOTA_UNIT_TARGET_TEAM_ENEMY, DOTA_UNIT_TARGET_ALL, 0, FIND_ANY_ORDER, false)
for k,v in pairs(targets) do
if v.ChariotChargeHit ~= true then
v.ChariotChargeHit = true
Timers:CreateTimer(1.0, function()
v.ChariotChargeHit = false
end)
DoDamage(caster, v, keys.ChargeDamage * currentMS / 100, DAMAGE_TYPE_MAGICAL, 0, keys.ability, false)
v:AddNewModifier(caster, v, "modifier_stunned", {Duration = 1.25})
end
end
return 0.1
end})

Similar to Black Rider's timer leak, the Charge timer is not cleared.

On a side note, I still think Hammer charge has memory leaks, but that might be removed so just indicating here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions