From beb6a1048ecc851dd5907656bf16e56ac8486c19 Mon Sep 17 00:00:00 2001 From: Mish Ushakov <10400064+mishushakov@users.noreply.github.com> Date: Thu, 25 Jun 2026 21:25:16 +0200 Subject: [PATCH] fix(ci): notify success on releases that skip CLI tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit report-success used `if: needs.publish.result == 'success'`, which lacks a status-check function. When cli-tests is skipped (a release that doesn't bump the CLI), GitHub Actions skip propagation cascades through the dependency graph and skips report-success too — so no Slack success notification fires, even though publish succeeded. Guard the condition with `(!cancelled())` (the same pattern the publish job already uses) so the `if` is actually evaluated regardless of upstream skips, while still only notifying when publish succeeded. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e6444ba193..a35b8384a1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -164,7 +164,7 @@ jobs: report-success: needs: [preflight, publish] - if: needs.publish.result == 'success' + if: (!cancelled()) && needs.publish.result == 'success' name: Release Succeeded - Slack Notification runs-on: ubuntu-latest steps: