JuliaPackage: Allow running tests in a dedicated test_step#4124
Closed
Crivella wants to merge 1 commit into
Closed
JuliaPackage: Allow running tests in a dedicated test_step#4124Crivella wants to merge 1 commit into
JuliaPackage: Allow running tests in a dedicated test_step#4124Crivella wants to merge 1 commit into
Conversation
2 tasks
Contributor
Author
|
Closing in favor of #4146 which includes these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only way to run the testsuite of a Julia package is to do so in the
sanity_check_commandsThis PR adds a way to use
runtestandtestcmdin the extension options to run the test suite of the package after installation.To discuss
The alternative currently would be to install the test dependencies as normal one so that they are available to the test step. Alternatively we would need to add a new
test_depflag to Julia package so that the extension can be downloaded and added to the test_dir during test but would require altering the current logic a lotjulia_cmddetection similar topython_cmdforPythonPackage