From caf64d8f205a9494d257f4084526a927e9190f02 Mon Sep 17 00:00:00 2001 From: Neha Burnwal Date: Fri, 19 Dec 2025 11:27:47 +0530 Subject: [PATCH] Caught the exception when a version is malformed in target file --- .../src/org/eclipse/pde/internal/ui/PDEUIMessages.java | 2 ++ .../internal/ui/editor/targetdefinition/TargetEditor.java | 6 +++++- .../src/org/eclipse/pde/internal/ui/pderesources.properties | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java index 1ea86406bb..64dc410130 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java @@ -3218,6 +3218,8 @@ public class PDEUIMessages extends NLS { public static String TargetEditor_6; + public static String TargetEditor_7; + public static String FeatureImportWizardPage_importHasInvalid; public static String ProductInfoSection_plugins; diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java index 137cb76be0..6596bffb8a 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java @@ -195,6 +195,10 @@ protected void pageChange(int newPageIndex) { setActivePage(fSourceTabIndex); CoreException ce = new CoreException(Status.error(e.getMessage(), e)); showError(PDEUIMessages.TargetEditor_5, ce); + } catch (IllegalArgumentException e) { + setActivePage(fSourceTabIndex); + CoreException ce = new CoreException(Status.error(e.getMessage(), e)); + showError(PDEUIMessages.TargetEditor_7, ce); } } @@ -557,7 +561,7 @@ private ITargetDefinition loadTargetDefinition() throws CoreException { ITargetHandle externalTarget = service.getTarget(((IURIEditorInput) fInput).getURI()); fTarget = externalTarget.getTargetDefinition(); } - } catch (CoreException e) { + } catch (CoreException | IllegalArgumentException e) { fTarget = service.newTarget(); throw e; } diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties index 333482bffa..0f75f8c7b1 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties @@ -1998,6 +1998,7 @@ TargetEditor_3=Unable to perform save TargetEditor_4=Target Editor TargetEditor_5=Unable to load target definition model. Fix the target definition model in Source View. TargetEditor_6=The editor input ''{0}'' is not supported. +TargetEditor_7=Unable to parse the IU version. Fix the target definition model in Source View. TargetCreationPage_0=Initialize the target definition with: TargetCreationPage_1=Nothing: Start &with an empty target definition TargetCreationPage_2=&Default: Default target for the running platform