From d0bf7faf414775231fce966b15658299631f9c41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20L=C3=A4ubrich?= Date: Tue, 24 Mar 2026 06:24:36 +0100 Subject: [PATCH] Replace StringBuffer with StringBuilder in BundleHelper The local variable `buffer` in `getFilter()` is not shared across threads, so StringBuilder is the appropriate choice and avoids unnecessary synchronization overhead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../src/org/eclipse/pde/internal/build/BundleHelper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/BundleHelper.java b/build/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/BundleHelper.java index 8ed52ba24c0..e42a4966600 100644 --- a/build/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/BundleHelper.java +++ b/build/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/BundleHelper.java @@ -187,7 +187,7 @@ public Filter getFilter(BundleDescription bundleDescription) { if (supplierFilters.size() == 1) { nativeFilter = supplierFilters.get(0).toString(); } else if (supplierFilters.size() > 1) { - StringBuffer buffer = new StringBuffer("(|"); //$NON-NLS-1$ + StringBuilder buffer = new StringBuilder("(|"); //$NON-NLS-1$ for (Filter filter : supplierFilters) { buffer.append(filter.toString()); }