From 54d3eed8e032348f599a96a747ee5223304e56bb Mon Sep 17 00:00:00 2001 From: Marcus Hoepfner Date: Tue, 10 Mar 2026 10:14:37 +0100 Subject: [PATCH] [FIX] dispose code mining providers Fixes: https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/2856 JDT does the same in JavaEditor.uninstallJavaCodeMining(). Seems that this was completely missing for e.g. text editords. --- .../jface/internal/text/codemining/CodeMiningManager.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java index 52352047e06..b66400f2b85 100644 --- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java +++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java @@ -118,6 +118,9 @@ public void uninstall() { if (fInlinedAnnotationSupport != null) { fInlinedAnnotationSupport.updateAnnotations(Collections.emptySet()); } + if (fCodeMiningProviders != null) { + fCodeMiningProviders.forEach(ICodeMiningProvider::dispose); + } } /**