From c1aa26260ae4bfe6a13de50ecbbdbe11768a7f95 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Wed, 21 Jan 2026 13:58:55 +0000 Subject: [PATCH 1/6] Add unit test job --- .github/workflows/tests.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ee14515c..6495c660 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,10 +18,17 @@ on: merge_group: types: [checks_requested] jobs: - test: + rust_tests: uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read pull-requests: read with: bazel-target: 'test //src/...' + unit_test: + uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main + permissions: + contents: read + pull-requests: read + with: + bazel-target: 'test //tests/ut/...' From c19a2a15a343c4a72a632a1e2264a11c5e6363b7 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Wed, 21 Jan 2026 14:59:51 +0000 Subject: [PATCH 2/6] Renamed jobs --- .github/workflows/tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 6495c660..b4d9f068 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,14 +18,16 @@ on: merge_group: types: [checks_requested] jobs: - rust_tests: + rust-tests: + name: "Run Rust tests" uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read pull-requests: read with: bazel-target: 'test //src/...' - unit_test: + unit-tests: + name: "Run Unit tests" uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read From 6c50e6620cb5528317e65cba15050c3f4adb2699 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Thu, 22 Jan 2026 15:54:09 +0000 Subject: [PATCH 3/6] Simplified test action to prevent rebuilding for each test type --- .github/workflows/tests.yml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b4d9f068..301dcdc8 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,19 +18,11 @@ on: merge_group: types: [checks_requested] jobs: - rust-tests: - name: "Run Rust tests" + test: + name: "Run tests" uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read pull-requests: read with: - bazel-target: 'test //src/...' - unit-tests: - name: "Run Unit tests" - uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main - permissions: - contents: read - pull-requests: read - with: - bazel-target: 'test //tests/ut/...' + bazel-target: 'test //src/... //tests/ut/...' \ No newline at end of file From e09332b50558311abdcce716dadc341793045f54 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Thu, 22 Jan 2026 16:04:51 +0000 Subject: [PATCH 4/6] Fix formatting --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 301dcdc8..e239ab02 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -25,4 +25,4 @@ jobs: contents: read pull-requests: read with: - bazel-target: 'test //src/... //tests/ut/...' \ No newline at end of file + bazel-target: 'test //src/... //tests/ut/...' From f2caaaea729f9d95ba1ef266c1bc914853ee4525 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Mon, 26 Jan 2026 12:52:48 +0000 Subject: [PATCH 5/6] Moved UT to src directory --- .github/workflows/tests.yml | 2 +- src/launch_manager_daemon/BUILD | 2 +- .../process_state_client_lib/BUILD | 17 ++++++++++--- .../src}/processstateclient_UT.cpp | 0 tests/ut/BUILD | 15 ----------- tests/ut/processstateclient_UT/BUILD | 25 ------------------- 6 files changed, 16 insertions(+), 45 deletions(-) rename {tests/ut/processstateclient_UT => src/launch_manager_daemon/process_state_client_lib/src}/processstateclient_UT.cpp (100%) delete mode 100644 tests/ut/BUILD delete mode 100644 tests/ut/processstateclient_UT/BUILD diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e239ab02..eb1459ba 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -25,4 +25,4 @@ jobs: contents: read pull-requests: read with: - bazel-target: 'test //src/... //tests/ut/...' + bazel-target: 'test //src/...' diff --git a/src/launch_manager_daemon/BUILD b/src/launch_manager_daemon/BUILD index eb69e23f..a18d5545 100644 --- a/src/launch_manager_daemon/BUILD +++ b/src/launch_manager_daemon/BUILD @@ -54,6 +54,7 @@ cc_binary_with_common_opts( cc_library( name = "headers", + testonly = True, hdrs = glob( [ "src/**/*.h", @@ -65,7 +66,6 @@ cc_library( "include", "src", ], - visibility = ["//tests:__subpackages__"], deps = [ # Must match launch_manager deps ":config", diff --git a/src/launch_manager_daemon/process_state_client_lib/BUILD b/src/launch_manager_daemon/process_state_client_lib/BUILD index 117e53de..3d6d3ac5 100644 --- a/src/launch_manager_daemon/process_state_client_lib/BUILD +++ b/src/launch_manager_daemon/process_state_client_lib/BUILD @@ -10,8 +10,6 @@ # # SPDX-License-Identifier: Apache-2.0 # ******************************************************************************* -package(default_visibility = ["//tests:__subpackages__"]) - cc_library( name = "process_state_client", srcs = [ @@ -40,6 +38,7 @@ cc_library( cc_library( name = "headers", + testonly = True, hdrs = glob( [ "include/score/lcm/**/*.h", @@ -51,7 +50,6 @@ cc_library( "include", "src", ], - visibility = ["//tests:__subpackages__"], deps = [ # Must match process_state_client deps "//externals/ipc_dropin", @@ -63,3 +61,16 @@ cc_library( "@score_baselibs//score/result", ], ) + +cc_test( + name = "processstateclient_UT", + srcs = [ + "src/processstateclient_UT.cpp", + "//src/launch_manager_daemon/process_state_client_lib:src/processstatenotifier.cpp", + "//src/launch_manager_daemon/process_state_client_lib:src/processstatereceiver.cpp", + ], + deps = [ + "//src/launch_manager_daemon/process_state_client_lib:headers", + "@googletest//:gtest_main", + ], +) diff --git a/tests/ut/processstateclient_UT/processstateclient_UT.cpp b/src/launch_manager_daemon/process_state_client_lib/src/processstateclient_UT.cpp similarity index 100% rename from tests/ut/processstateclient_UT/processstateclient_UT.cpp rename to src/launch_manager_daemon/process_state_client_lib/src/processstateclient_UT.cpp diff --git a/tests/ut/BUILD b/tests/ut/BUILD deleted file mode 100644 index 7997e0ea..00000000 --- a/tests/ut/BUILD +++ /dev/null @@ -1,15 +0,0 @@ -# ******************************************************************************* -# Copyright (c) 2026 Contributors to the Eclipse Foundation -# -# See the NOTICE file(s) distributed with this work for additional -# information regarding copyright ownership. -# -# This program and the accompanying materials are made available under the -# terms of the Apache License Version 2.0 which is available at -# https://www.apache.org/licenses/LICENSE-2.0 -# -# SPDX-License-Identifier: Apache-2.0 -# ******************************************************************************* -load("@rules_cc//cc:defs.bzl", "cc_library") - -# Define mock cc libraries here if needed diff --git a/tests/ut/processstateclient_UT/BUILD b/tests/ut/processstateclient_UT/BUILD deleted file mode 100644 index 1eece866..00000000 --- a/tests/ut/processstateclient_UT/BUILD +++ /dev/null @@ -1,25 +0,0 @@ -# ******************************************************************************* -# Copyright (c) 2026 Contributors to the Eclipse Foundation -# -# See the NOTICE file(s) distributed with this work for additional -# information regarding copyright ownership. -# -# This program and the accompanying materials are made available under the -# terms of the Apache License Version 2.0 which is available at -# https://www.apache.org/licenses/LICENSE-2.0 -# -# SPDX-License-Identifier: Apache-2.0 -# ******************************************************************************* -cc_test( - name = "processstateclient_UT", - srcs = [ - "processstateclient_UT.cpp", - "//src/launch_manager_daemon/process_state_client_lib:src/processstatenotifier.cpp", - "//src/launch_manager_daemon/process_state_client_lib:src/processstatereceiver.cpp", - ], - visibility = ["//tests:__subpackages__"], - deps = [ - "//src/launch_manager_daemon/process_state_client_lib:headers", - "@googletest//:gtest_main", - ], -) From 3d69487332ddbd5d1bfc804b13c96a8fd69d649c Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Mon, 26 Jan 2026 13:35:37 +0000 Subject: [PATCH 6/6] Removed tests from copyright check --- BUILD | 1 - 1 file changed, 1 deletion(-) diff --git a/BUILD b/BUILD index 38e53208..ec623137 100644 --- a/BUILD +++ b/BUILD @@ -25,7 +25,6 @@ copyright_checker( srcs = [ "examples", "src", - "tests", "//:BUILD", "//:MODULE.bazel", ],