MarkerLayout not working when module is minified

[gribnoysup]

When module is minified, this comparison doesn't work because components name is minified as well

switch (component.type.name) {
    case 'MarkerLayout':
        this._setupMarkerLayout(component);
        break;
    case 'BalloonLayout':
        this._setupBalloonLayout(component);
        break;
    default:
        break;
}

I created a PR with possible solution #21

[dmitry-sher]

+1

It would be smarter to use CONSTANTS like

const MARKER_LAYOUT = "MarkerLayout";
switch() {
  case MARKER_LAYOUT: 
  ...
}

[gribnoysup]

@dropfen constants with strings still will not help when file is minified because component displayName is not provided for MarkerLayout and BallonLayout. So there are two options (maybe more, I can come up with only two now):

• provide displayName for MarkerLayout and BallonLayout components
• compare component.type, not component.type.name (this is what I am proposing in Change MarkerLayout, BalloonLayout component name comparison to type comparison #21)

my point is to use constants instead of all strings ( e.g dislayName: MARKER_LAYOUT etc. )

Am 13.09.16 um 15:54 schrieb Sergey:

@dropfen https://github.com/dropfen constants with strings still
will not help when file is minified because component |displayName| is
not provided for |MarkerLayout| and |BallonLayout|. So there are two
options (maybe more, I can come up with only two now):

• provide |displayName| for |MarkerLayout| and |BallonLayout| components
• compare |component.type|, not |component.type.name| (this is what
  I am proposing in Change MarkerLayout, BalloonLayout component name comparison to type comparison #21
  Change MarkerLayout, BalloonLayout component name comparison to type comparison #21)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKYhzluog7uMQIiNGD51CuapNWL9Tlyks5qpqsogaJpZM4JZ1wQ.