From 537cb332254be029c31eae39b17de2d745041e3d Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Mon, 23 Jun 2025 18:56:33 -0500 Subject: [PATCH 1/9] feat: tighten up the world to a more minimal geometry --- compact/definitions.xml | 13 +++++++++---- templates/epic.xml.jinja2 | 10 +++++++++- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/compact/definitions.xml b/compact/definitions.xml index fa6fb28729..9d91ee7e47 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -9,10 +9,15 @@ ## World volume - - - - + + + + + + + + + ## Detector IDs diff --git a/templates/epic.xml.jinja2 b/templates/epic.xml.jinja2 index 687347a0e4..5072dfded6 100644 --- a/templates/epic.xml.jinja2 +++ b/templates/epic.xml.jinja2 @@ -96,7 +96,15 @@ The world is a simple box, but could be a union of multiple regions. - + + + + + + + + + From fea81587f84fe06fcfa356025455c5c026600d4d Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Mon, 23 Jun 2025 19:00:29 -0500 Subject: [PATCH 2/9] fix: comment --- templates/epic.xml.jinja2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/epic.xml.jinja2 b/templates/epic.xml.jinja2 index 5072dfded6..0456a91ba2 100644 --- a/templates/epic.xml.jinja2 +++ b/templates/epic.xml.jinja2 @@ -93,7 +93,7 @@ ## World Volume - The world is a simple box, but could be a union of multiple regions. + The world is a union of multiple regions. From c21dfcdc2321891122101629dcf3706fe9f12119 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Tue, 24 Jun 2025 15:31:45 -0500 Subject: [PATCH 3/9] fix: increase backward_dy, forward_dx; reduce (backward,forward)_dz --- compact/definitions.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/compact/definitions.xml b/compact/definitions.xml index 9d91ee7e47..94d34c2bcc 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -10,14 +10,14 @@ ## World volume - - + + - + - + ## Detector IDs From 1a98c450662e0b7c4d9e8be86330db5b1fe601b7 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Tue, 24 Jun 2025 17:19:32 -0500 Subject: [PATCH 4/9] feat: allow x displacement of far forward world component --- compact/definitions.xml | 1 + templates/epic.xml.jinja2 | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/compact/definitions.xml b/compact/definitions.xml index 94d34c2bcc..acb2523426 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -15,6 +15,7 @@ + diff --git a/templates/epic.xml.jinja2 b/templates/epic.xml.jinja2 index 0456a91ba2..e1f650500b 100644 --- a/templates/epic.xml.jinja2 +++ b/templates/epic.xml.jinja2 @@ -103,7 +103,7 @@ - + From 315f0f21c40041533bf0607775ce87d133e6df47 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Tue, 24 Jun 2025 17:20:08 -0500 Subject: [PATCH 5/9] fix: don't hardcode world in far forward vacuum --- compact/far_forward/vacuum.xml | 2 ++ src/magnetVacuumFF.cpp | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/compact/far_forward/vacuum.xml b/compact/far_forward/vacuum.xml index 15b2688ca6..cb3dd62d41 100644 --- a/compact/far_forward/vacuum.xml +++ b/compact/far_forward/vacuum.xml @@ -59,6 +59,8 @@ + + diff --git a/src/magnetVacuumFF.cpp b/src/magnetVacuumFF.cpp index 2f26763206..7f924778d2 100644 --- a/src/magnetVacuumFF.cpp +++ b/src/magnetVacuumFF.cpp @@ -99,6 +99,9 @@ static Ref_t create_detector(Detector& det, xml_h e, SensitiveDetector /* sens * z_elem_magnet.push_back(pos_z * dd4hep::cm); } + xml_comp_t x_end_of_the_world = x_det.child(_Unicode(end_of_the_world)); + double end_of_the_world_z = x_end_of_the_world.attr(_Unicode(z)); + int numMagnets = radii_magnet.size(); //number of actual FF magnets between IP and FF detectors int numGaps = numMagnets - @@ -265,7 +268,7 @@ static Ref_t create_detector(Detector& det, xml_h e, SensitiveDetector /* sens * int pieceIdx = numMagnets - 1; // last B2PF magnet std::string piece_name = Form("GapVacuum%d", numGaps + numMagnets + 1); - double endGapLength = (10000.0 - z_end[pieceIdx]) / cos(rotation_magnet[pieceIdx]); + double endGapLength = (end_of_the_world_z - z_end[pieceIdx]) / cos(rotation_magnet[pieceIdx]); endGapLength = endGapLength - 4 * radii_magnet[pieceIdx] * From b19d8c84b39c88ca81885f1b1b77d3b30bf9b1e0 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Tue, 24 Jun 2025 17:45:27 -0500 Subject: [PATCH 6/9] feat: allow x displacement of far backward world component --- compact/definitions.xml | 1 + templates/epic.xml.jinja2 | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/compact/definitions.xml b/compact/definitions.xml index acb2523426..ecb52334b8 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -9,6 +9,7 @@ ## World volume + diff --git a/templates/epic.xml.jinja2 b/templates/epic.xml.jinja2 index e1f650500b..107c2836b9 100644 --- a/templates/epic.xml.jinja2 +++ b/templates/epic.xml.jinja2 @@ -100,7 +100,7 @@ - + From ef66205f7f9982ea8a25fa95b786f5b8b0e33e89 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Tue, 24 Jun 2025 17:45:52 -0500 Subject: [PATCH 7/9] fix: increase backward_dz to fit ip6_extended --- compact/definitions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compact/definitions.xml b/compact/definitions.xml index ecb52334b8..ee35464033 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -12,7 +12,7 @@ - + From 3b96c53de172c4ee91e7c094a37e4d7216925406 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Wed, 16 Jul 2025 11:08:13 -0500 Subject: [PATCH 8/9] fix: increase far forward y height to fit B1(A)PF --- compact/definitions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compact/definitions.xml b/compact/definitions.xml index ee35464033..f3e3cb2f48 100644 --- a/compact/definitions.xml +++ b/compact/definitions.xml @@ -18,7 +18,7 @@ - + From 1f239e96a079fc009e6a62bf48e8dd3b032dc673 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Wed, 23 Jul 2025 11:29:27 -0500 Subject: [PATCH 9/9] fix: stop the fudging --- .../tracking/central_tracker_hybrid_v2.xml | 52 +++++++++---------- compact/tracking/silicon_barrel.xml | 3 ++ compact/tracking/silicon_disks.xml | 42 +++++++-------- compact/tracking/tof_endcap.xml | 4 +- compact/tracking/vertex_barrel.xml | 2 +- 5 files changed, 53 insertions(+), 50 deletions(-) diff --git a/compact/tracking/central_tracker_hybrid_v2.xml b/compact/tracking/central_tracker_hybrid_v2.xml index 925192edfe..a4aa68a661 100644 --- a/compact/tracking/central_tracker_hybrid_v2.xml +++ b/compact/tracking/central_tracker_hybrid_v2.xml @@ -156,8 +156,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + Place asymmetrically in the layer (module sits near the bottom). @@ -238,7 +238,7 @@ total X0 0.24% per disk layer (4 sectors per disk): Global Si endcap variables - + @@ -259,11 +259,11 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + - - + + @@ -565,8 +565,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -576,8 +576,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + The tracker endcap ends at the same place as the outer tracker barrel that sits around it @@ -762,8 +762,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -772,8 +772,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -782,8 +782,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + The Si tracker endcap ends at position of the last disk @@ -800,8 +800,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + @@ -810,8 +810,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + The Si tracker endcap ends at position of the last disk @@ -973,7 +973,7 @@ total X0 0.24% per disk layer (4 sectors per disk): - + Parameters for the "ring" GEMS around the silicon tracker, which are all identical @@ -993,8 +993,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + z position of the "ring" GEMS, note that some are offset slightly @@ -1031,8 +1031,8 @@ total X0 0.24% per disk layer (4 sectors per disk): - - + + diff --git a/compact/tracking/silicon_barrel.xml b/compact/tracking/silicon_barrel.xml index bcf66a007f..be62e72aec 100644 --- a/compact/tracking/silicon_barrel.xml +++ b/compact/tracking/silicon_barrel.xml @@ -60,6 +60,9 @@ + + + diff --git a/compact/tracking/silicon_disks.xml b/compact/tracking/silicon_disks.xml index 94ac075ea6..6c37ba5007 100644 --- a/compact/tracking/silicon_disks.xml +++ b/compact/tracking/silicon_disks.xml @@ -28,7 +28,7 @@ Global Si endcap variables - + Acts envelope buffer distances @@ -46,8 +46,8 @@ - - + + @@ -56,8 +56,8 @@ - - + + @@ -134,8 +134,8 @@ - - + + @@ -143,8 +143,8 @@ - - + + @@ -152,8 +152,8 @@ - - + + @@ -161,8 +161,8 @@ - - + + @@ -171,8 +171,8 @@ - - + + @@ -180,8 +180,8 @@ - - + + @@ -189,8 +189,8 @@ - - + + symmetric N and P disks (5 each) @@ -199,8 +199,8 @@ - - + + diff --git a/compact/tracking/tof_endcap.xml b/compact/tracking/tof_endcap.xml index cff627ee19..2f2396e848 100644 --- a/compact/tracking/tof_endcap.xml +++ b/compact/tracking/tof_endcap.xml @@ -107,8 +107,8 @@ - - + + diff --git a/compact/tracking/vertex_barrel.xml b/compact/tracking/vertex_barrel.xml index 7a1eaf4535..eebf3830ed 100644 --- a/compact/tracking/vertex_barrel.xml +++ b/compact/tracking/vertex_barrel.xml @@ -53,7 +53,7 @@ - place holder, not used for now bur required for CI checks + - Currently there are 3 sensor layers: Layer 1,2,3 = L0, L1, L2. - assume they are of the same length and aligned.