Inclusion of Whisker Spray

[AltamiroAJ]

Hello,

I created a fork to add the Whisker Spray resistance, starting it with something a bit simpler before going in the complexity of the Lewandowski equations for stability.

I read the code a couple of times already but I am not sure how you handled the conversion problem. While the paper is using equations for the imperial system, the code uses the metric system.

Did you just include conversion factors on the equations?

[elcf]

Hi, good question, particularly since some of the empirical equations have units mixed into their constants. OpenPlaning right now assumes inputs with the metric system. Some equations you'll notice are unchanged simply because those equations are non-dimensional (so the unit system bookkeeping is already taken cared of by consistently using the metric system). One example that uses dimensional equations is the get_seaway_behavior function. There, I just converted the metric system input to imperial, and then converted the imperial results back to metric (you can see the conversions in lines 872-880 and 994). I opted to use the original dimensional equations in the imperial system, since that way it would be easy to look at the equations and directly compare them to the original paper as they were written.

[AltamiroAJ]

I opted to use the original dimensional equations in the imperial system, since that way it would be easy to look at the equations and directly compare them to the original paper as they were written.

This was exactly what I was thinking, but I asked because I want to keep the code consistency as much as possible.
Thanks for the response