Skip to content

[bug] Dismissed PR reviews remain in review_summary scoring counts #204

Description

@jony376

Description

ReviewHandler stores pull_request_review.submitted events but ignores pull_request_review.dismissed. Dismissed maintainer CHANGES_REQUESTED reviews therefore remain in the reviews table, and pr_review_summary keeps counting them toward maintainer_changes_requested_count and changes_requested_count used by Gittensor mirror scoring.

Steps to Reproduce

  1. Mirror a registered repo where a maintainer submits CHANGES_REQUESTED on a PR (pull_request_review.submitted).
  2. Confirm the review row exists in reviews and miners API review_summary shows maintainer_changes_requested_count = 1.
  3. On GitHub, the maintainer dismisses that review (pull_request_review.dismissed).
  4. Observe ReviewHandler returns early because action !== "submitted".
  5. Query miners pulls for that PR: maintainer_changes_requested_count is still 1.

Expected Behavior

Dismissed reviews no longer contribute to pr_review_summary counts.

Actual Behavior

Dismissed CHANGES_REQUESTED rows stay in reviews and continue to penalize mirror scoring.

Environment

  • OS: Linux
  • Runtime/Node version: Node 20

Additional Context

Handler location: packages/das/src/webhook/handlers/review.handler.ts. Aggregator: packages/db/21_view_pr_review_summary.sql.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions