Description
ReviewHandler stores pull_request_review.submitted events but ignores pull_request_review.dismissed. Dismissed maintainer CHANGES_REQUESTED reviews therefore remain in the reviews table, and pr_review_summary keeps counting them toward maintainer_changes_requested_count and changes_requested_count used by Gittensor mirror scoring.
Steps to Reproduce
- Mirror a registered repo where a maintainer submits
CHANGES_REQUESTED on a PR (pull_request_review.submitted).
- Confirm the review row exists in
reviews and miners API review_summary shows maintainer_changes_requested_count = 1.
- On GitHub, the maintainer dismisses that review (
pull_request_review.dismissed).
- Observe
ReviewHandler returns early because action !== "submitted".
- Query miners pulls for that PR:
maintainer_changes_requested_count is still 1.
Expected Behavior
Dismissed reviews no longer contribute to pr_review_summary counts.
Actual Behavior
Dismissed CHANGES_REQUESTED rows stay in reviews and continue to penalize mirror scoring.
Environment
- OS: Linux
- Runtime/Node version: Node 20
Additional Context
Handler location: packages/das/src/webhook/handlers/review.handler.ts. Aggregator: packages/db/21_view_pr_review_summary.sql.
Description
ReviewHandlerstorespull_request_review.submittedevents but ignorespull_request_review.dismissed. Dismissed maintainerCHANGES_REQUESTEDreviews therefore remain in thereviewstable, andpr_review_summarykeeps counting them towardmaintainer_changes_requested_countandchanges_requested_countused by Gittensor mirror scoring.Steps to Reproduce
CHANGES_REQUESTEDon a PR (pull_request_review.submitted).reviewsand miners APIreview_summaryshowsmaintainer_changes_requested_count = 1.pull_request_review.dismissed).ReviewHandlerreturns early becauseaction !== "submitted".maintainer_changes_requested_countis still1.Expected Behavior
Dismissed reviews no longer contribute to
pr_review_summarycounts.Actual Behavior
Dismissed
CHANGES_REQUESTEDrows stay inreviewsand continue to penalize mirror scoring.Environment
Additional Context
Handler location:
packages/das/src/webhook/handlers/review.handler.ts. Aggregator:packages/db/21_view_pr_review_summary.sql.