test: expand unit coverage across 13 packages#64
Merged
Conversation
…g, and more Add ~4,700 lines of unit tests covering: concurrent claim dedup and cancellation (scheduler), dispatch client round-trips, tar extraction traversal rejection (cni, dind), streaming temp file paths, forgerunner command parsing and secret masking, GitHub token refresh and webhook rollback, localtunnel reconnect scheduling, metrics label cardinality, networking subnet retry/fallback, runtime log cleanup and pull mutex serialization, VM SSH key material, workflow container coverage, and config provider/duration edges. Also fixes blank error discards (_ =) in dispatch_test.go and renames the concurrent test's fakeDispatchServer to avoid redeclaration.
luthermonson
force-pushed
the
tests/combined-unit-coverage
branch
from
13494b2 to
402ea20
Compare
Resolved conflicts and pre-existing lint failures so this branch can land: Conflicts (5 files): - pkg/dind/build_linux_test.go (add/add — took main's BuildKit-aware version) - pkg/runtime/logclean_test.go (content — took main's) - pkg/scheduler/concurrent_test.go (add/add — took main's) - pkg/scheduler/dispatch_test.go (content — took main's) - pkg/vm/embed_test.go (content — took main's) Main has independently grown test coverage for these files since this branch was opened — the conflict resolutions favor main throughout because (a) main is current and references current production code, and (b) the branch's versions were testing earlier API surfaces (e.g. pre-BuildKit /build handler in pkg/dind/build_linux_test.go) that no longer exist after PR #68 etc. Lint fix: - Delete pkg/dind/extract_buildcontext_linux_test.go — referenced undefined `extractBuildContext` (the function was renamed to `extractBuildContextToTempDir` with a different signature on main; pkg/dind/buildkit_build_test.go already covers the new signature including path-traversal rejection). Verified locally: `CGO_ENABLED=0 go test ./...` passes for every package in the module on this Windows host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ =) in existing dispatch_test.goTest plan
mage lintpasses (0 issues)TestPushHandlerEndToEndfails on Windows — requires containerd privileges, also fails on main)