chore(ci): gate arm64/macOS matrix jobs on repo vars + continue-on-error#75
Open
luthermonson wants to merge 1 commit into
Open
chore(ci): gate arm64/macOS matrix jobs on repo vars + continue-on-error#75luthermonson wants to merge 1 commit into
luthermonson wants to merge 1 commit into
Conversation
Build (Linux arm64) and Build (macOS arm64) have been sitting in
"Pending" forever on every PR because no self-hosted runner with the
matching labels is online. That makes the PR checks UI look broken
and trains people to ignore yellow checks.
Two changes per gated job:
if: ${{ vars.HAS_<ARCH>_RUNNER == 'true' }}
Job is "Skipped" rather than "Pending" when the operator hasn't
set the corresponding repo variable. To re-enable once a runner
is online:
gh variable set HAS_LINUX_ARM64_RUNNER --body true
gh variable set HAS_MACOS_ARM64_RUNNER --body true
continue-on-error: true
Even when the runner IS online, a failure here doesn't fail the
PR check group. These two platforms aren't covered by the
primary CI runner so we tolerate flake there.
Windows amd64 stays required (no gate, no continue-on-error) — the
self-hosted Windows runner is live on the build machine and the
build sanity check is genuinely useful there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the arm64/macOS matrix builds from sitting in Pending on every PR. Two changes per gated job:
```
gh variable set HAS_LINUX_ARM64_RUNNER --body true
gh variable set HAS_MACOS_ARM64_RUNNER --body true
```
`Build (Windows amd64)` is unchanged — the self-hosted Windows runner is live (it's this box) and that build sanity check is genuinely useful.
Background
PR #73 and #74 both have `Build (Linux arm64)` and `Build (macOS arm64)` stuck Pending right now. Those PRs are otherwise green and merge-ready; this fixes the symptom that makes them look not-merge-ready.
Test plan
Follow-ups
Branch protection rules (settings/branches) may still list `Build (Linux arm64)` / `Build (macOS arm64)` as required checks — if so, merges on PRs where these are Skipped will be blocked. Check that and either remove them from required, or rely on Skipped counting as success (GitHub's docs say it does for required-checks purposes since `if:`-skipped jobs report `conclusion: skipped` which the merge gate accepts).