Thanks for wanting to add a feature to Kubernetes! You will be responsible for guiding
your feature through completion, and asking the right people for approvals.
Large features typically go through three stages: Alpha, Beta, and Stable
Each stage requires various approvals from various teams.
You can use the checkboxes below to
track your progress. You can delete the text above once you have read it. Please keep the checklist.
- Before Alpha
- Before Beta
- Before Stable
More advice:
Design
- If the feature is simple, the approver might ask you to write a longer design doc.
- If there is a design doc, that goes in a PR under github.com/kubernetes/kubernetes/docs/proposals. Link that PR on this issue.
- Once you get LGTM from a feature reviewer, you can check this checkbox, and the reviewer will apply the "feature-lgtm" label.
- If your code changes an API (
/pkg/apis/...), it needs an API review.
Coding
- Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
- As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
- When you are done with the code, apply the "code-complete" label.
- When the feature has user docs, please add a comment mentioning @kubernetes/feature-complete-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing. They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.
Docs
Thanks for wanting to add a feature to Kubernetes! You will be responsible for guiding
your feature through completion, and asking the right people for approvals.
Large features typically go through three stages: Alpha, Beta, and Stable
Each stage requires various approvals from various teams.
You can use the checkboxes below to
track your progress. You can delete the text above once you have read it. Please keep the checklist.
More advice:
Design
/pkg/apis/...), it needs an API review.Coding
and sometimes http://github.com/kubernetes/contrib, or other repos.
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing. They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.
Docs