Skip to content

Commit a2e9557

Browse files
author
Dylan Huang
committed
Refactor _load_secrets_from_env_file to return all environment variables and remove API_KEY filtering logic
1 parent 82ffc3a commit a2e9557

1 file changed

Lines changed: 1 addition & 17 deletions

File tree

eval_protocol/cli_commands/upload.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ def _resolve_entry_to_qual_and_source(entry: str, cwd: str) -> tuple[str, str]:
136136
def _load_secrets_from_env_file(env_file_path: str) -> Dict[str, str]:
137137
"""
138138
Load secrets from a .env file that should be uploaded to Fireworks.
139-
140-
Returns a dictionary of secret key-value pairs that contain 'API_KEY' in the name.
141139
"""
142140
if not os.path.exists(env_file_path):
143141
return {}
@@ -152,14 +150,7 @@ def _load_secrets_from_env_file(env_file_path: str) -> Dict[str, str]:
152150
key = key.strip()
153151
value = value.strip().strip('"').strip("'") # Remove quotes
154152
env_vars[key] = value
155-
156-
# Filter for secrets that look like API keys
157-
secrets = {}
158-
for key, value in env_vars.items():
159-
if "API_KEY" in key.upper() and value:
160-
secrets[key] = value
161-
162-
return secrets
153+
return env_vars
163154

164155

165156
def _mask_secret_value(value: str) -> str:
@@ -193,13 +184,6 @@ def upload_command(args: argparse.Namespace) -> int:
193184
selected_tests = _discover_and_select_tests(root, non_interactive=non_interactive)
194185
if not selected_tests:
195186
return 1
196-
# Warn about parameterized tests
197-
parameterized_tests = [t for t in selected_tests if t.has_parametrize]
198-
if parameterized_tests:
199-
print("\nNote: Parameterized tests will be uploaded as a single evaluator that")
200-
print(" handles all parameter combinations. The evaluator will work with")
201-
print(" the same logic regardless of which model/parameters are used.")
202-
203187
selected_specs = [(t.qualname, t.file_path) for t in selected_tests]
204188

205189
base_id = getattr(args, "id", None)

0 commit comments

Comments
 (0)