Skip to content

Commit b9826c3

Browse files
author
Dylan Huang
committed
fix smoke test params
1 parent a1173d6 commit b9826c3

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

eval_protocol/pytest/evaluation_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def evaluation_test( # noqa: C901
5959
evaluation_test_kwargs: Optional[List[EvaluationInputParam]] = None,
6060
rollout_processor_kwargs: Optional[RolloutProcessorInputParam] = None,
6161
aggregation_method: AggregationMethod = "mean",
62-
passed_threshold: Optional[Union[EvaluationThreshold, float]] = None,
62+
passed_threshold: Optional[Union[EvaluationThreshold, float, dict]] = None,
6363
num_runs: int = 1,
6464
max_dataset_rows: Optional[int] = None,
6565
mcp_config_path: Optional[str] = None,

tests/test_tau_bench_airline_smoke.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,13 @@ def tau_bench_airline_smoke_to_evaluation_row(data: List[Dict[str, Any]]) -> Lis
6565
@evaluation_test(
6666
input_dataset=["tests/pytest/data/airline_dataset.jsonl"],
6767
dataset_adapter=tau_bench_airline_smoke_to_evaluation_row,
68-
model=["fireworks_ai/accounts/fireworks/models/gpt-oss-120b"],
69-
rollout_input_params=[{"temperature": 0.8, "extra_body": {"reasoning_effort": "medium"}}],
68+
completion_params=[
69+
{
70+
"temperature": 0.8,
71+
"extra_body": {"reasoning_effort": "medium"},
72+
"model": "fireworks_ai/accounts/fireworks/models/gpt-oss-120b",
73+
}
74+
],
7075
rollout_processor=default_mcp_gym_rollout_processor,
7176
passed_threshold=0.36,
7277
num_runs=1, # Smoke test: single run for quick feedback

0 commit comments

Comments
 (0)