add port parameter testes

Author: Dylan Huang

tests/test_logs_server.py

@@ -346,6 +346,35 @@ def test_serve_logs_convenience_function(self, temp_build_dir):
             # Verify that the run method was called
             mock_run.assert_called_once()
 
+    def test_serve_logs_port_parameter(self, temp_build_dir):
+        """Test that serve_logs properly passes the port parameter to LogsServer."""
+        with patch("eval_protocol.utils.logs_server.LogsServer") as mock_logs_server_class:
+            mock_server_instance = Mock()
+            mock_logs_server_class.return_value = mock_server_instance
+
+            # Call serve_logs with a specific port
+            test_port = 9000
+            serve_logs(port=test_port)
+
+            # Verify that LogsServer was created with the correct port
+            mock_logs_server_class.assert_called_once_with(port=test_port)
+            # Verify that the run method was called on the instance
+            mock_server_instance.run.assert_called_once()
+
+    def test_serve_logs_default_port(self, temp_build_dir):
+        """Test that serve_logs uses default port when none is specified."""
+        with patch("eval_protocol.utils.logs_server.LogsServer") as mock_logs_server_class:
+            mock_server_instance = Mock()
+            mock_logs_server_class.return_value = mock_server_instance
+
+            # Call serve_logs without specifying a port
+            serve_logs()
+
+            # Verify that LogsServer was created with None port (which will use LogsServer's default of 8000)
+            mock_logs_server_class.assert_called_once_with(port=None)
+            # Verify that the run method was called on the instance
+            mock_server_instance.run.assert_called_once()
+
     @pytest.mark.asyncio
     async def test_run_async_lifecycle(self, temp_build_dir):
         """Test the async lifecycle of the server."""
@@ -445,6 +474,72 @@ def test_health_endpoint(self, temp_build_dir_with_files):
         data = response.json()
         assert data["status"] == "ok"
 
+    @pytest.mark.asyncio
+    async def test_server_runs_on_specific_port(self, temp_build_dir_with_files):
+        """Integration test: verify that LogsServer actually runs on the specified port (async requests)."""
+        import socket
+
+        import httpx
+
+        # Find an available port for testing
+        def find_free_port():
+            with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
+                s.bind(("", 0))
+                s.listen(1)
+                port = s.getsockname()[1]
+            return port
+
+        test_port = find_free_port()
+
+        # Create and start server in background
+        server = LogsServer(build_dir=str(temp_build_dir_with_files), port=test_port)
+
+        # Start server in background task
+        server_task = asyncio.create_task(server.run_async())
+
+        try:
+            # Wait longer for server to start and be ready
+            await asyncio.sleep(3)
+
+            async with httpx.AsyncClient() as client:
+                # Test that we can actually connect to the server on the specified port
+                response = await client.get(f"http://localhost:{test_port}/", timeout=10)
+                assert response.status_code == 200
+                assert "Test" in response.text
+
+                # Test the health endpoint
+                response = await client.get(f"http://localhost:{test_port}/health", timeout=10)
+                assert response.status_code == 200
+                data = response.json()
+                assert data["status"] == "ok"
+
+        finally:
+            # Clean up
+            server_task.cancel()
+            try:
+                await server_task
+            except asyncio.CancelledError:
+                pass
+
+    def test_serve_logs_port_parameter_integration(self, temp_build_dir_with_files):
+        """Integration test: verify that serve_logs function actually works with port parameter."""
+        # This test verifies that serve_logs creates LogsServer with the correct port
+        # without actually starting the server
+        test_port = 9999
+
+        # Use a different approach - mock the LogsServer class and verify the port parameter
+        with patch("eval_protocol.utils.logs_server.LogsServer") as mock_logs_server_class:
+            mock_server_instance = Mock()
+            mock_logs_server_class.return_value = mock_server_instance
+
+            # Call serve_logs with specific port
+            serve_logs(port=test_port)
+
+            # Verify that LogsServer was created with the correct port
+            mock_logs_server_class.assert_called_once_with(port=test_port)
+            # Verify that the run method was called on the instance
+            mock_server_instance.run.assert_called_once()
+
 
 @pytest.mark.asyncio
 class TestAsyncWebSocketOperations: