Skip to content

Tick-freezes due to biome search indexing? #101

@CodeBot101

Description

@CodeBot101

Describe the Bug

  • Fieldguide version 1.6.9 (the dropdown only goes up to 1.6.8 right now)
  • Minecraft 1.20.1
  • Forge 47.4.9

Within about an hour of playing a new world (or less), the server tends to freeze up with a bunch of "TIMED_WAITING" errors. The last couple of crashes seemed to be due to Fieldguide sending an "ExportContentPacket" to the client. The handler calls "ClientFieldGuideManager.clearCache()", "ClientCategoryManager.resolveAllEntries()", "SearchManager.getMatches()", and "SearchManager.matchByBiome()", which calls "String.split()" in a loop across every registered entry. With a large modpack (400+ mods and a big biome pool from Terralith), this sometimes blocks the render thread for over 40 seconds, which causes the watchdog to kill the game.

Full crash log

Potentially relevant stack trace:

at java.lang.String.split(String.java:3419)
at com.evandev.fieldguide.client.search.SearchManager.matchByBiome(SearchManager.java:190)
at com.evandev.fieldguide.client.search.SearchManager.getMatches(SearchManager.java:71)
at com.evandev.fieldguide.client.manager.ClientCategoryManager.resolveAllEntries(ClientCategoryManager.java:128)
at com.evandev.fieldguide.client.ClientFieldGuideManager.clearCache(ClientFieldGuideManager.java:50)
at com.evandev.fieldguide.network.ExportContentPacket.handleClient(ExportContentPacket.java:24)

Reproduction Steps

  1. You can try to use my modpack, if you want, lol
  2. You should be able to just create a new world and sort of explore around and play for a while, and it'll eventually lock up and freeze after maybe an hour or less—try generating chunks. Although full transparency: There may be a FEW things wrong with the mod pack causing it to freeze up at the moment, lol, but at least ONE of the reasons for freezing seems to be this mod, lul

Expected Result

No TPS freezes; if "resolveAllEntries" isn't already running in the background, making it do so could free up the render thread so TPS doesn't freeze (at least not as much) when it's triggered.

Screenshots and Videos

No response

Operating System

Windows 11 Version 25H2

Mod Version

1.6.8

Minecraft Version

1.20.1

Mod Loader

Forge

Other Mods / Modpack

Modpack: SCE Protocol (unreleased version)

Additional Context

https://mclo.gs/C19rNTG

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions