Create Bill Complete Task, Mark Project Finished

[everbee7]

Creating a Billing Task:

If a billing task is created and active, the job can’t be marked as “stagnant.”

• Add server logic to prevent this when updating project status
• There is project automation that updates this project stage, not sure how best to handle
• Should return an error if the user sets to stagnant from the UI
• Check unit tests

Improvement:
When creating a "Bill Complete" task manually

Prompt: “You are creating a “Bill Complete” task. Do you want to mark the job as Finished?”
If the user selects Yes:
Set job/wo project stage to Finished
Set the Finish Date = Today’s date
This prevents conflicts with logic requiring a finish date

[wearedood]

Great feature request! This billing task and project completion logic is crucial for maintaining data integrity. Here's a comprehensive approach to implement this:

Implementation Strategy

1. Server-Side Validation Logic

// Example validation function
function validateProjectStatusUpdate(projectId, newStatus, existingTasks) {
  if (newStatus === 'stagnant') {
    const activeBillingTasks = existingTasks.filter(task => 
      task.type === 'billing' && task.status === 'active'
    );
    
    if (activeBillingTasks.length > 0) {
      throw new ValidationError({
        code: 'ACTIVE_BILLING_TASKS_EXIST',
        message: 'Cannot mark project as stagnant while active billing tasks exist',
        activeTasks: activeBillingTasks.map(t => t.id)
      });
    }
  }
}

2. Project Automation Handling

// Middleware for project stage updates
const projectStageMiddleware = async (req, res, next) => {
  try {
    const { projectId, newStage } = req.body;
    await validateProjectStatusUpdate(projectId, newStage, await getTasks(projectId));
    next();
  } catch (error) {
    return res.status(400).json({
      error: error.message,
      code: error.code,
      suggestions: ['Complete or cancel active billing tasks first']
    });
  }
};

3. UI Error Handling

// Frontend error handling
const handleProjectStatusChange = async (projectId, newStatus) => {
  try {
    await updateProjectStatus(projectId, newStatus);
  } catch (error) {
    if (error.code === 'ACTIVE_BILLING_TASKS_EXIST') {
      showModal({
        title: 'Cannot Update Project Status',
        message: 'Active billing tasks prevent marking this project as stagnant.',
        actions: [
          { label: 'View Billing Tasks', action: () => navigateToTasks(projectId) },
          { label: 'Cancel', action: () => closeModal() }
        ]
      });
    }
  }
};

4. Bill Complete Task Enhancement

// Enhanced bill complete task creation
const createBillCompleteTask = async (projectId, taskData) => {
  const project = await getProject(projectId);
  
  // Show completion prompt
  const userWantsToFinish = await showConfirmDialog({
    title: 'Mark Project as Finished?',
    message: 'You are creating a "Bill Complete" task. Do you want to mark the job as Finished?',
    options: ['Yes, mark as finished', 'No, keep current status']
  });
  
  if (userWantsToFinish) {
    await Promise.all([
      createTask(taskData),
      updateProject(projectId, { 
        stage: 'Finished',
        finishDate: new Date().toISOString(),
        completedBy: getCurrentUser().id
      })
    ]);
  } else {
    await createTask(taskData);
  }
};

5. Unit Tests Structure

describe('Project Status Validation', () => {
  test('should prevent stagnant status with active billing tasks', async () => {
    const projectId = 'test-project';
    const activeBillingTask = { id: 1, type: 'billing', status: 'active' };
    
    await expect(
      validateProjectStatusUpdate(projectId, 'stagnant', [activeBillingTask])
    ).rejects.toThrow('Cannot mark project as stagnant');
  });
  
  test('should allow stagnant status with no active billing tasks', async () => {
    const projectId = 'test-project';
    const completedBillingTask = { id: 1, type: 'billing', status: 'completed' };
    
    await expect(
      validateProjectStatusUpdate(projectId, 'stagnant', [completedBillingTask])
    ).resolves.not.toThrow();
  });
});

6. Database Considerations

• Add database constraints to enforce business rules
• Consider using database triggers for additional validation
• Implement audit logging for status changes

7. Implementation Checklist

• Create validation middleware
• Update project status API endpoints
• Implement UI error handling
• Add bill complete task prompt
• Write comprehensive unit tests
• Add integration tests
• Update API documentation

Would you like me to help implement any specific part of this logic or create detailed test cases? Happy to contribute to this important feature! 💼✅