Detect dead code from stub

[SleeplessByte]

The following four placeholders are present in the stubs. They should be detected and a "must-fix" message should be added to remove the line which is now dead-code.

throw new Error('Please implement the (...) function')
throw new Error('Remove this line and implement the function')
throw new Error('Implement the (...) function')
throw new Error('Remove this statement and implement this function');

[IsaacG]

Is this an opportunity to switch them all to one consistent message style?

[SleeplessByte]

We would still need to support older versions, but yes, I have no issue with all of the messages being the same in the JS and TS track!

[jagdish-15]

I'll be happy to switch them all to one consistent message and raise a PR on both the JS and TS tracks for the same. Just let me know which message should be used consistently throughout the track!

[SleeplessByte]

@Cool-Katt what is your preferred stub message?

[Cool-Katt]

I aways use

throw new Error('Remove this statement and implement this function');

But maybe this one can also work, in the light of being more direct

throw new Error('Remove this line and implement the function');

[SleeplessByte]

Yah I like throw new Error('Remove this line and implement the function');, but technically it's the statement to remove not the line, but I think it's fine in this case.

Let's go with

throw new Error('Remove this line and implement the function');

[jagdish-15]

exercism/javascript#2714 (JS Concept)
exercism/javascript#2715 (JS Practice)
exercism/typescript#1591 (TS Practice)

[jagdish-15]

All concept exercises in the TS track (there was only one, apparently) already had the correct throw new line, so no changes were needed there!

[naderakhgari]

Hi @SleeplessByte, I can fix this issue in PR but I think I don't have access to raise a PR. Is this still a valid issue to fix?

[SleeplessByte]

Yes, ping me in the pr and i can reopen it