From 5eecb57b10115330ea9ccaecb4bcaf54567ed6fc Mon Sep 17 00:00:00 2001 From: Andy Fragen Date: Wed, 15 Apr 2026 14:06:00 -0700 Subject: [PATCH 1/3] add error checking in add_package_to_release_cache() Signed-off-by: Andy Fragen --- inc/packages/namespace.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/inc/packages/namespace.php b/inc/packages/namespace.php index 0c0dbc62..3815471b 100644 --- a/inc/packages/namespace.php +++ b/inc/packages/namespace.php @@ -938,6 +938,9 @@ function add_package_to_release_cache( string $did ) : void { } $releases = get_site_transient( CACHE_RELEASE_PACKAGES ) ?: []; $releases[ $did ] = get_latest_release_from_did( $did ); + if ( is_wp_error( $releases[ $did ] ) ) { + unset( $releases[ $did ] ); + } set_site_transient( CACHE_RELEASE_PACKAGES, $releases ); } From f6b612bec82faa92e6c30a86c656820b14fe913f Mon Sep 17 00:00:00 2001 From: Andy Fragen Date: Wed, 15 Apr 2026 16:21:01 -0700 Subject: [PATCH 2/3] Update inc/packages/namespace.php Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com> Signed-off-by: Andy Fragen --- inc/packages/namespace.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/inc/packages/namespace.php b/inc/packages/namespace.php index 3815471b..efef6be7 100644 --- a/inc/packages/namespace.php +++ b/inc/packages/namespace.php @@ -936,12 +936,13 @@ function add_package_to_release_cache( string $did ) : void { if ( empty( $did ) ) { return; } - $releases = get_site_transient( CACHE_RELEASE_PACKAGES ) ?: []; - $releases[ $did ] = get_latest_release_from_did( $did ); - if ( is_wp_error( $releases[ $did ] ) ) { - unset( $releases[ $did ] ); + $latest_release = get_latest_release_from_did( $did ); + if ( is_wp_error( $latest_release ) ) { + return; } - set_site_transient( CACHE_RELEASE_PACKAGES, $releases ); + $releases = get_site_transient( CACHE_RELEASE_PACKAGES ) ?: []; + $releases[ $did ] = $latest_release; + set_site_transient( CACHE_RELEASE_PACKAGES, $releases ); } /** From 0358de9e5ac25364447e38a50a5cba9597bf2764 Mon Sep 17 00:00:00 2001 From: Andy Fragen Date: Wed, 15 Apr 2026 16:23:15 -0700 Subject: [PATCH 3/3] phpcs Signed-off-by: Andy Fragen --- inc/packages/namespace.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/inc/packages/namespace.php b/inc/packages/namespace.php index efef6be7..28ee8886 100644 --- a/inc/packages/namespace.php +++ b/inc/packages/namespace.php @@ -936,13 +936,13 @@ function add_package_to_release_cache( string $did ) : void { if ( empty( $did ) ) { return; } - $latest_release = get_latest_release_from_did( $did ); + $latest_release = get_latest_release_from_did( $did ); if ( is_wp_error( $latest_release ) ) { return; } - $releases = get_site_transient( CACHE_RELEASE_PACKAGES ) ?: []; - $releases[ $did ] = $latest_release; - set_site_transient( CACHE_RELEASE_PACKAGES, $releases ); + $releases = get_site_transient( CACHE_RELEASE_PACKAGES ) ?: []; + $releases[ $did ] = $latest_release; + set_site_transient( CACHE_RELEASE_PACKAGES, $releases ); } /**