From a78b7f36083af3140c2f98674485e5e7a78d689a Mon Sep 17 00:00:00 2001 From: Nitesh Kumar <166297874+niteshg97@users.noreply.github.com> Date: Tue, 26 May 2026 10:05:50 +0530 Subject: [PATCH 1/3] fix DynamicFlow optimizer updates --- hls4ml/model/flow/flow.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hls4ml/model/flow/flow.py b/hls4ml/model/flow/flow.py index 43415f5ac0..6a2185d721 100644 --- a/hls4ml/model/flow/flow.py +++ b/hls4ml/model/flow/flow.py @@ -62,10 +62,10 @@ def optimizers(self): return optimizers def _add_optimizer(self, opt_name): - self._added_optimizers.put(opt_name) + self._added_optimizers.add(opt_name) def _remove_optimizer(self, opt_name): - self._removed_optimizers.put(opt_name) + self._removed_optimizers.add(opt_name) flow_map = {} From 0279c020213cbea809b0edaba5e4700986535639 Mon Sep 17 00:00:00 2001 From: Nitesh Kumar <166297874+niteshg97@users.noreply.github.com> Date: Tue, 26 May 2026 10:11:12 +0530 Subject: [PATCH 2/3] Add DynamicFlow update regression test --- test/pytest/test_flows.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/pytest/test_flows.py b/test/pytest/test_flows.py index e46dde70d6..bc1726abbf 100644 --- a/test/pytest/test_flows.py +++ b/test/pytest/test_flows.py @@ -119,3 +119,11 @@ def test_flows(tester): expected = tester.expected_pass_order observed = tester.observed_pass_order assert success, f'Tester {i} fails: expected ({expected}), observed ({observed})' + + + + +def test_update_dynamic_flow(): + dynamic_flow = hls4ml.model.flow.register_flow('TestDynamicFlowUpdate', lambda: ['A', 'B']) + hls4ml.model.flow.update_flow(dynamic_flow, add_optimizers=['C'], remove_optimizers=['A']) + assert set(hls4ml.model.flow.get_flow(dynamic_flow).optimizers) == {'B', 'C'} From 691f5fa169e0dab546b8536973a51b1612d75747 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 26 May 2026 05:11:09 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit hooks --- test/pytest/test_flows.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/pytest/test_flows.py b/test/pytest/test_flows.py index bc1726abbf..297547e0e3 100644 --- a/test/pytest/test_flows.py +++ b/test/pytest/test_flows.py @@ -121,8 +121,6 @@ def test_flows(tester): assert success, f'Tester {i} fails: expected ({expected}), observed ({observed})' - - def test_update_dynamic_flow(): dynamic_flow = hls4ml.model.flow.register_flow('TestDynamicFlowUpdate', lambda: ['A', 'B']) hls4ml.model.flow.update_flow(dynamic_flow, add_optimizers=['C'], remove_optimizers=['A'])