From a0e6e4e63335861a2c4dfb3e167d54c2f9d464d3 Mon Sep 17 00:00:00 2001 From: Maximilian Hoffmann Date: Tue, 17 Mar 2026 13:49:21 +0100 Subject: [PATCH] fix: pass REACT_NATIVE_MINOR_VERSION to pod target xcconfig The version_flags define was set via `s.xcconfig` which only applies to the consumer (app target), not to the pod's own compilation. This caused `REACT_NATIVE_MINOR_VERSION` to be undefined (defaulting to 0) when compiling FastSquircle's .mm files, making the `#if < 81` guard compile the legacy code path on RN >= 0.82. Move the flag to `s.pod_target_xcconfig` so it reaches the pod's own build. Fixes fbeccaceci/react-native-fast-squircle#24 --- FastSquircle.podspec | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/FastSquircle.podspec b/FastSquircle.podspec index fa937f9..0ef9e0f 100644 --- a/FastSquircle.podspec +++ b/FastSquircle.podspec @@ -23,11 +23,8 @@ Pod::Spec.new do |s| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', - 'SWIFT_COMPILATION_MODE' => 'wholemodule' - } - - s.xcconfig = { - "OTHER_CFLAGS" => "$(inherited) #{version_flags}", + 'SWIFT_COMPILATION_MODE' => 'wholemodule', + 'OTHER_CFLAGS' => "$(inherited) #{version_flags}" } install_modules_dependencies(s)