Conversation
Owner
Author
|
Vou dar review em breve |
guilherme-gm
suggested changes
Dec 21, 2017
guilherme-gm
left a comment
guilherme-gm
left a comment
There was a problem hiding this comment.
Fiz uma review bem rápida, espero não ter esquecido nada importante haha no geral são só alguns mini cuidados para se ter :) muito bom
| $idProduto = filter_var($idProduto, FILTER_SANITIZE_NUMBER_INT); | ||
| if ($idProduto != FALSE) { | ||
| $this->data['produto'] = Produto::getProdutoPorId($idProduto); | ||
| } |
| public static function getFuncionarios() { | ||
| $conn = DB::getConnection(); | ||
|
|
||
| $query = 'SELECT idFuncionario, nome, usuario, senha, cargo FROM funcionario'; |
There was a problem hiding this comment.
tabela deve ter nome igual do modelo, no caso com o F maiusculo, se não causará problemas em sistemas case-sensitive (linux)
| <input type="text" name="nome" id="nome" class="form-control" value="<?= $produto->getNome() ?>" placeholder="Nome"/> | ||
| </div> | ||
| <div class="form-group"> | ||
| <label for="titulo">Descricao</label> |
There was a problem hiding this comment.
o atributo for das labels estão sempre apontando pra "titulo" e não para os campos certos
| <h3>Novo Produto</h3> | ||
| <form method="POST" action=""> | ||
| <div class="form-group"> | ||
| <label for="titulo">Nome</label> |
There was a problem hiding this comment.
os o atributo for das labels estão sempre apontando pra "titulo" e não para os campos certos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.