fix: handle null positional args before matchers#271
Open
a1573595 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Fixes #256.
This fixes positional matcher reconstruction when a real nullable positional argument appears before an argument matcher.
Example:
Previously, mocktail treated any positional
nullas a possible matcher placeholder. That caused the realnullargument to be consumed as the matcher position, shifting the actual matcher and making verification or capture fail.The change keeps the existing fallback-value reconstruction model, but removes the blanket
nullshortcut. Positional matchers are now reconstructed only when the invocation argument matches a stored matcher fallback value. This preserves literalnullarguments as real arguments while still supportingany()andcaptureAny().Added regression coverage for:
nullfollowed byany()nullwithcaptureAny()Type of Change