Skip to content

Commit 8dfbfc7

Browse files
fix: remove duplicate sub pipe in FileHandle.pm
The `sub pipe` function was defined twice in FileHandle.pm: - Lines 41-46: early definition added to ensure defined(&pipe) returns true before the IO::Handle import filter on line 52 - Lines 103-108: the original definition that was never removed This caused a "Subroutine pipe redefined" warning when warnings were enabled (e.g. via jcpan -j 8 -t DateTime::Format::ICal). Remove the second (redundant) definition. The early definition at lines 41-46 is sufficient and correctly placed. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent 2034066 commit 8dfbfc7

2 files changed

Lines changed: 1 addition & 13 deletions

File tree

src/main/java/org/perlonjava/core/Configuration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public final class Configuration {
3333
* Automatically populated by Gradle/Maven during build.
3434
* DO NOT EDIT MANUALLY - this value is replaced at build time.
3535
*/
36-
public static final String gitCommitId = "ed722c0cd";
36+
public static final String gitCommitId = "20340661d";
3737

3838
/**
3939
* Git commit date of the build (ISO format: YYYY-MM-DD).

src/main/perl/lib/FileHandle.pm

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -95,18 +95,6 @@ sub import {
9595
};
9696
}
9797

98-
################################################
99-
# This is the only exported function we define;
100-
# the rest come from other classes.
101-
#
102-
103-
sub pipe {
104-
my $r = IO::Handle->new;
105-
my $w = IO::Handle->new;
106-
CORE::pipe($r, $w) or return undef;
107-
($r, $w);
108-
}
109-
11098
# Rebless standard file handles
11199
bless *STDIN{IO}, "FileHandle" if ref *STDIN{IO} eq "IO::Handle";
112100
bless *STDOUT{IO}, "FileHandle" if ref *STDOUT{IO} eq "IO::Handle";

0 commit comments

Comments
 (0)