fix: jperldoc now finds perlfunc, perlop and other core documentation#395
Merged
Conversation
…navailable
When fork support is not available (d_fork is undef), the Process
iterator falls back to using open($out, "$command|") instead of
IPC::Open3. In this mode, the handle does not have a valid fileno
and cannot be used with IO::Select.
Previously, get_select_handles would return these unusable handles,
causing the TAP::Parser::Multiplexer to silently fail when trying
to add them to IO::Select. This resulted in jprove reporting
Files=0, Tests=0 even when test files existed.
The fix checks if {sel} is defined before returning handles. When
{sel} is undef, we are using the simple open() fallback which
does not support select-based reading.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- Import Perl 5 core pod documentation (perlfunc.pod, perlop.pod, etc.) into src/main/perl/lib/Pod/ directory - Update build.gradle to include .pod files in the JAR - Update Pod::Perldoc to search both pod/ and Pod/ directories since JAR paths are case-sensitive - Add pod import configuration to dev/import-perl5/config.yaml The pod files are now bundled in the JAR and jperldoc can find them. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
6331b93 to
e0338d0
Compare
Add **/*.pod include pattern to pom.xml resources to match the build.gradle configuration, ensuring jperldoc works when building with Maven. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.podfiles as resourcespod/andPod/directories (JAR paths are case-sensitive)Problem
jperldoc perlfuncandjperldoc perlopwere returning "No documentation found" because:pod/(lowercase) while macOS createsPod/(capitalized)Solution
**/*.podpattern to build.gradle resource configurationsearchforfunction to also tryPod/(capitalized) directoryTesting
Test plan
makepasses (builds and runs unit tests)./jperldoc perlfuncshows documentation./jperldoc perlopshows documentation./jperldoc File::Basenamestill works (module docs)Generated with Devin