From a1ed97db18b57339e66efc8c6f0a2dc78cc672bc Mon Sep 17 00:00:00 2001
From: Bryan Kendall <bkend@google.com>
Date: Thu, 26 Feb 2026 08:24:18 -0800
Subject: [PATCH] catch errors during App Hosting deploys

---
 CHANGELOG.md                     |  1 +
 src/deploy/apphosting/release.ts | 10 +++++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e69de29bb2d..ac7cf55e0e3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -0,0 +1 @@
+- Detects when App Hosting fails to deploy, returning an error. (#8866)
diff --git a/src/deploy/apphosting/release.ts b/src/deploy/apphosting/release.ts
index d4927603e5d..33056fd06f5 100644
--- a/src/deploy/apphosting/release.ts
+++ b/src/deploy/apphosting/release.ts
@@ -11,6 +11,7 @@ import {
   logLabeledWarning,
 } from "../../utils";
 import { Context } from "./args";
+import { FirebaseError } from "../../error";
 
 /**
  * Orchestrates rollouts for the backends targeted for deployment.
@@ -70,6 +71,7 @@ export default async function (context: Context, options: Options): Promise<void
     `Starting rollout(s) for backend(s) ${backendIds.join(", ")}; this may take a few minutes. It's safe to exit now.\n`,
   ).start();
   const results = await Promise.allSettled(rollouts);
+  let failed = false;
   for (let i = 0; i < results.length; i++) {
     const res = results[i];
     if (res.status === "fulfilled") {
@@ -77,9 +79,15 @@ export default async function (context: Context, options: Options): Promise<void
       logLabeledSuccess("apphosting", `Rollout for backend ${backendIds[i]} complete!`);
       logLabeledSuccess("apphosting", `Your backend is now deployed at:\n\thttps://${backend.uri}`);
     } else {
+      failed = true;
       logLabeledWarning("apphosting", `Rollout for backend ${backendIds[i]} failed.`);
-      logLabeledError("apphosting", res.reason);
+      logLabeledError("apphosting", `${res.reason}`);
     }
   }
   rolloutsSpinner.stop();
+  if (failed) {
+    throw new FirebaseError(
+      "One or more rollouts failed. Please review the errors above and try again.",
+    );
+  }
 }